From cf373b5690aa137e51fd49cd7f0e8ba38ef8adea Mon Sep 17 00:00:00 2001 From: "mvstanton@chromium.org" Date: Tue, 12 Mar 2013 15:37:23 +0000 Subject: [PATCH] Use an efficient graph constant in CodeStubGraphBuilderBase::BuildGraph(). Improve printing for HReturn. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/12585004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13913 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/code-stubs-hydrogen.cc | 7 +++---- src/hydrogen-instructions.cc | 3 +++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc index ab2fb08a..bb8bfe3 100644 --- a/src/code-stubs-hydrogen.cc +++ b/src/code-stubs-hydrogen.cc @@ -132,14 +132,13 @@ bool CodeStubGraphBuilderBase::BuildGraph() { // it's essential to bind this value to the environment in case of deopt start_environment->Bind(param_count, stack_parameter_count); AddInstruction(stack_parameter_count); + arguments_length_ = stack_parameter_count; } else { ASSERT(descriptor_->environment_length() == param_count); - stack_parameter_count = AddInstruction(new(zone) - HConstant(-1, Representation::Integer32())); + stack_parameter_count = graph()->GetConstantMinus1(); + arguments_length_ = graph()->GetConstant0(); } - arguments_length_ = stack_parameter_count; - context_ = new(zone) HContext(); AddInstruction(context_); start_environment->BindContext(context_); diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc index eca1aea..8399f0b 100644 --- a/src/hydrogen-instructions.cc +++ b/src/hydrogen-instructions.cc @@ -1034,6 +1034,9 @@ void HIsNilAndBranch::PrintDataTo(StringStream* stream) { void HReturn::PrintDataTo(StringStream* stream) { value()->PrintNameTo(stream); + stream->Add(" (pop "); + parameter_count()->PrintNameTo(stream); + stream->Add(" values)"); } -- 2.7.4