From ce90943f9538fa037f56d40972593c5911b7a1dc Mon Sep 17 00:00:00 2001 From: =?utf8?q?Olivier=20Cr=C3=AAte?= Date: Fri, 24 Jan 2014 03:02:38 -0500 Subject: [PATCH] socket: Add note that the packet dropping in tcp-bsd is broken behavior --- socket/tcp-bsd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/socket/tcp-bsd.c b/socket/tcp-bsd.c index 6e54b22..5792129 100644 --- a/socket/tcp-bsd.c +++ b/socket/tcp-bsd.c @@ -285,6 +285,9 @@ socket_send_message (NiceSocket *sock, const NiceOutputMessage *message) ret = message->length; } } else { + /* FIXME: This dropping will break http/socks5/etc + * We probably need a way to the upper layer to control reliability + */ /* If the queue is too long, drop whatever packets we can. */ if (g_queue_get_length (&priv->send_queue) >= MAX_QUEUE_LENGTH) { guint peek_idx = 0; -- 2.7.4