From ce7de39e6a34443784eea7fe79f72128a4182579 Mon Sep 17 00:00:00 2001 From: "sergio@webkit.org" Date: Wed, 18 Jan 2012 17:40:46 +0000 Subject: [PATCH] [GTK] [regression] A couple of tests failing after r105253 https://bugs.webkit.org/show_bug.cgi?id=76549 Reviewed by Gustavo Noronha Silva. Fixes a regression added by r105253. The method that RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn() instead of popsMenuByArrowKeys(). No new tests as it's already covered by fast/forms/select-popup-pagekeys.html and fast/forms/select/menulist-onchange-fired-with-key-up-down.html that started to fail after the revision mentioned above. * platform/gtk/RenderThemeGtk.h: (WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105286 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebCore/ChangeLog | 19 +++++++++++++++++++ Source/WebCore/platform/gtk/RenderThemeGtk.h | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog index f4ce94b..3a23a7f 100644 --- a/Source/WebCore/ChangeLog +++ b/Source/WebCore/ChangeLog @@ -1,3 +1,22 @@ +2012-01-18 Sergio Villar Senin + + [GTK] [regression] A couple of tests failing after r105253 + https://bugs.webkit.org/show_bug.cgi?id=76549 + + Reviewed by Gustavo Noronha Silva. + + Fixes a regression added by r105253. The method that + RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn() + instead of popsMenuByArrowKeys(). + + No new tests as it's already covered by + fast/forms/select-popup-pagekeys.html and + fast/forms/select/menulist-onchange-fired-with-key-up-down.html + that started to fail after the revision mentioned above. + + * platform/gtk/RenderThemeGtk.h: + (WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn): + 2012-01-18 Andrey Kosyakov Web Inspector: omit compression field in HAR entries for resources coming from cache diff --git a/Source/WebCore/platform/gtk/RenderThemeGtk.h b/Source/WebCore/platform/gtk/RenderThemeGtk.h index ade1691..ea61674 100644 --- a/Source/WebCore/platform/gtk/RenderThemeGtk.h +++ b/Source/WebCore/platform/gtk/RenderThemeGtk.h @@ -82,7 +82,7 @@ public: virtual void systemFont(int propId, FontDescription&) const; virtual Color systemColor(int cssValueId) const; - virtual bool popsMenuByArrowKeys() const OVERRIDE { return true; } + virtual bool popsMenuBySpaceOrReturn() const OVERRIDE { return true; } #if ENABLE(VIDEO) virtual String extraMediaControlsStyleSheet(); -- 2.7.4