From ce70fc824397fe115a8083c14d4ea401a9a804c4 Mon Sep 17 00:00:00 2001
From: Davis Goodin <dagood@microsoft.com>
Date: Wed, 26 Jun 2019 10:07:13 -0500
Subject: [PATCH] Add forward-focused comments per review

Commit migrated from https://github.com/dotnet/core-setup/commit/4650eed8685f30a6919f9a7b249d75a8baf3e4e7
---
 src/installer/managed/CommonManaged.props                         | 5 ++++-
 src/installer/pkg/packaging-tools/framework.sharedfx.targets      | 3 ++-
 .../netcoreapp/sfx/Microsoft.NETCore.App.SharedFx.sfxproj         | 8 ++++++--
 tools-local/tasks/core-setup.tasks.csproj                         | 2 +-
 4 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/src/installer/managed/CommonManaged.props b/src/installer/managed/CommonManaged.props
index bef7ccf..5195cc2 100644
--- a/src/installer/managed/CommonManaged.props
+++ b/src/installer/managed/CommonManaged.props
@@ -19,7 +19,10 @@
     <!--
       Arcade specifies a default en-US NeutralLanguage, which creates a
       System.Resources.NeutralResourcesLanguageAttribute that doesn't compile with existing
-      references for PlatformAbstractions on netstandard1.3. Remove it for now.
+      references for PlatformAbstractions on netstandard1.3. Clearing NeutralLanguage removes it.
+
+      If this Arcade SDK feature is desired in the future, this will need to be worked through. No
+      issue tracks this as of writing.
     -->
     <NeutralLanguage></NeutralLanguage>
   </PropertyGroup>
diff --git a/src/installer/pkg/packaging-tools/framework.sharedfx.targets b/src/installer/pkg/packaging-tools/framework.sharedfx.targets
index 8c82baa..97ee3e1 100644
--- a/src/installer/pkg/packaging-tools/framework.sharedfx.targets
+++ b/src/installer/pkg/packaging-tools/framework.sharedfx.targets
@@ -198,7 +198,8 @@
 
   <!--
     Ensure the pkgproj is already built. This isn't a real ProjectReference because the SDK doesn't
-    seem to handle pkgproj nicely for Publish. For now we're using its nupkg directly.
+    seem to handle pkgproj nicely for Publish. For now, we're using its nupkg directly. In the
+    future, this will be handled in shared tooling to generate shared frameworks in the Arcade SDK.
   -->
   <Target Name="BuildPkgProjectReferences">
     <MSBuild Projects="@(PkgProjectReference)" Targets="Build" />
diff --git a/src/installer/pkg/projects/netcoreapp/sfx/Microsoft.NETCore.App.SharedFx.sfxproj b/src/installer/pkg/projects/netcoreapp/sfx/Microsoft.NETCore.App.SharedFx.sfxproj
index 7caad43..301ca2b 100644
--- a/src/installer/pkg/projects/netcoreapp/sfx/Microsoft.NETCore.App.SharedFx.sfxproj
+++ b/src/installer/pkg/projects/netcoreapp/sfx/Microsoft.NETCore.App.SharedFx.sfxproj
@@ -4,7 +4,10 @@
     <SfxIdentity>Microsoft.NETCore.App</SfxIdentity>
     <SfxPackageIdentity>$(SfxIdentity).Internal</SfxPackageIdentity>
 
-    <!-- Lay out the sfx in the legacy location for old packaging to keep working for now. -->
+    <!--
+      Lay out the sfx in the legacy location for old packaging to keep working for now. This can be
+      removed when the legacy infra is phased out.
+    -->
     <SharedFrameworkLayoutDir>$(SharedFrameworkPublishDir)</SharedFrameworkLayoutDir>
 
     <GenerateRuntimeGraph>true</GenerateRuntimeGraph>
@@ -22,7 +25,8 @@
 
   <!--
     Make sure the installer file is generated with the old infra's name and location. This allows
-    the existing infra to bundle it without any changes.
+    the existing infra to bundle it without any changes. This can be removed when the legacy infra
+    is phased out.
   -->
   <Target Name="PutSharedFrameworkMsiInLegacyLocation"
           DependsOnTargets="GetInstallerLocations"
diff --git a/tools-local/tasks/core-setup.tasks.csproj b/tools-local/tasks/core-setup.tasks.csproj
index 05d6bb1..7375619 100644
--- a/tools-local/tasks/core-setup.tasks.csproj
+++ b/tools-local/tasks/core-setup.tasks.csproj
@@ -38,7 +38,7 @@
     <Reference Include="System.IO.Compression" />
   </ItemGroup>
 
-  <!-- Remove source that require BuildTools to compile. -->
+  <!-- TODO: (arcade) Add this back, needed for publishing. Removed because it requires BuildTools to compile. -->
   <ItemGroup>
     <Compile Remove="FinalizeBuild.cs" />
   </ItemGroup>
-- 
2.7.4