From ce2160ab5da94c54803b01251881e2a6c6a39c6f Mon Sep 17 00:00:00 2001 From: Chris Michael Date: Thu, 21 Jul 2016 13:21:25 -0400 Subject: [PATCH] elementary: Remove logically dead code In all code paths leading to this goto statement being called, 'iter_array' variable will already be NULL, so checking it's validity is just logically dead code. Fixes Coverity CID1357392 @fix Signed-off-by: Chris Michael --- src/lib/elementary/elm_atspi_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/elm_atspi_bridge.c b/src/lib/elementary/elm_atspi_bridge.c index fbdbe8f..e33de9b 100644 --- a/src/lib/elementary/elm_atspi_bridge.c +++ b/src/lib/elementary/elm_atspi_bridge.c @@ -1158,6 +1158,7 @@ _action_actions_get(const Eldbus_Service_Interface *iface, const Eldbus_Message { const char *descr; char *key; + key = elm_interface_atspi_action_keybinding_get(obj, id); descr = elm_interface_atspi_action_description_get(obj, id); descr = descr ? descr : ""; @@ -1169,7 +1170,6 @@ _action_actions_get(const Eldbus_Service_Interface *iface, const Eldbus_Message return ret; error: - if (iter_array) eldbus_message_iter_container_close(iter, iter_array); if (ret) eldbus_message_unref(ret); return NULL; } -- 2.7.4