From ce1f6b2a3cd3f8e0aa41999676e3cf165124bb28 Mon Sep 17 00:00:00 2001 From: "whesse@chromium.org" Date: Tue, 23 Feb 2010 12:40:36 +0000 Subject: [PATCH] Add comment to generated code that says which code generator compiled it. Review URL: http://codereview.chromium.org/652110 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3932 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/arm/codegen-arm.cc | 1 + src/arm/fast-codegen-arm.cc | 1 + src/arm/full-codegen-arm.cc | 1 + src/ia32/codegen-ia32.cc | 1 + src/ia32/fast-codegen-ia32.cc | 1 + src/ia32/full-codegen-ia32.cc | 1 + src/x64/codegen-x64.cc | 1 + src/x64/fast-codegen-x64.cc | 1 + src/x64/full-codegen-x64.cc | 1 + 9 files changed, 9 insertions(+) diff --git a/src/arm/codegen-arm.cc b/src/arm/codegen-arm.cc index e47d392..5eb679b 100644 --- a/src/arm/codegen-arm.cc +++ b/src/arm/codegen-arm.cc @@ -145,6 +145,7 @@ Scope* CodeGenerator::scope() { return info_->function()->scope(); } void CodeGenerator::Generate(CompilationInfo* info) { // Record the position for debugging purposes. CodeForFunctionPosition(info->function()); + Comment cmnt(masm_, "[ function compiled by virtual frame code generator"); // Initialize state. info_ = info; diff --git a/src/arm/fast-codegen-arm.cc b/src/arm/fast-codegen-arm.cc index aa7128f..dad2af4 100644 --- a/src/arm/fast-codegen-arm.cc +++ b/src/arm/fast-codegen-arm.cc @@ -179,6 +179,7 @@ void FastCodeGenerator::EmitBitOr() { void FastCodeGenerator::Generate(CompilationInfo* compilation_info) { ASSERT(info_ == NULL); info_ = compilation_info; + Comment cmnt(masm_, "[ function compiled by fast code generator"); // Save the caller's frame pointer and set up our own. Comment prologue_cmnt(masm(), ";; Prologue"); diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc index 4896373..3aa2a00 100644 --- a/src/arm/full-codegen-arm.cc +++ b/src/arm/full-codegen-arm.cc @@ -56,6 +56,7 @@ void FullCodeGenerator::Generate(CompilationInfo* info, Mode mode) { ASSERT(info_ == NULL); info_ = info; SetFunctionPosition(function()); + Comment cmnt(masm_, "[ function compiled by full code generator"); if (mode == PRIMARY) { int locals_count = scope()->num_stack_slots(); diff --git a/src/ia32/codegen-ia32.cc b/src/ia32/codegen-ia32.cc index ecb4c49..62733ae 100644 --- a/src/ia32/codegen-ia32.cc +++ b/src/ia32/codegen-ia32.cc @@ -128,6 +128,7 @@ Scope* CodeGenerator::scope() { return info_->function()->scope(); } void CodeGenerator::Generate(CompilationInfo* info) { // Record the position for debugging purposes. CodeForFunctionPosition(info->function()); + Comment cmnt(masm_, "[ function compiled by virtual frame code generator"); // Initialize state. info_ = info; diff --git a/src/ia32/fast-codegen-ia32.cc b/src/ia32/fast-codegen-ia32.cc index f1c2507..4dcf232 100644 --- a/src/ia32/fast-codegen-ia32.cc +++ b/src/ia32/fast-codegen-ia32.cc @@ -621,6 +621,7 @@ void FastCodeGenerator::EmitBitOr() { void FastCodeGenerator::Generate(CompilationInfo* compilation_info) { ASSERT(info_ == NULL); info_ = compilation_info; + Comment cmnt(masm_, "[ function compiled by fast code generator"); // Save the caller's frame pointer and set up our own. Comment prologue_cmnt(masm(), ";; Prologue"); diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc index 2394bed..a7773d8 100644 --- a/src/ia32/full-codegen-ia32.cc +++ b/src/ia32/full-codegen-ia32.cc @@ -55,6 +55,7 @@ void FullCodeGenerator::Generate(CompilationInfo* info, Mode mode) { ASSERT(info_ == NULL); info_ = info; SetFunctionPosition(function()); + Comment cmnt(masm_, "[ function compiled by full code generator"); if (mode == PRIMARY) { __ push(ebp); // Caller's frame pointer. diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc index e418883..cba0e9e 100644 --- a/src/x64/codegen-x64.cc +++ b/src/x64/codegen-x64.cc @@ -280,6 +280,7 @@ void CodeGenerator::DeclareGlobals(Handle pairs) { void CodeGenerator::Generate(CompilationInfo* info) { // Record the position for debugging purposes. CodeForFunctionPosition(info->function()); + Comment cmnt(masm_, "[ function compiled by virtual frame code generator"); // Initialize state. info_ = info; diff --git a/src/x64/fast-codegen-x64.cc b/src/x64/fast-codegen-x64.cc index 4dbf26a..e78e3f8 100644 --- a/src/x64/fast-codegen-x64.cc +++ b/src/x64/fast-codegen-x64.cc @@ -188,6 +188,7 @@ void FastCodeGenerator::EmitBitOr() { void FastCodeGenerator::Generate(CompilationInfo* compilation_info) { ASSERT(info_ == NULL); info_ = compilation_info; + Comment cmnt(masm_, "[ function compiled by fast code generator"); // Save the caller's frame pointer and set up our own. Comment prologue_cmnt(masm(), ";; Prologue"); diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc index 30db660..5640177 100644 --- a/src/x64/full-codegen-x64.cc +++ b/src/x64/full-codegen-x64.cc @@ -55,6 +55,7 @@ void FullCodeGenerator::Generate(CompilationInfo* info, Mode mode) { ASSERT(info_ == NULL); info_ = info; SetFunctionPosition(function()); + Comment cmnt(masm_, "[ function compiled by full code generator"); if (mode == PRIMARY) { __ push(rbp); // Caller's frame pointer. -- 2.7.4