From cdb602b17548eeebb5e700c507d734ea5f887a49 Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Fri, 27 Feb 2015 15:38:32 +0000 Subject: [PATCH] Fixes a problem recognizing libraries created by Visual Studio. PR binutils/17910 * coffgen.c (_bfd_coff_internal_syment_name): Only check for string length overflow when the string table length is actually set. --- bfd/ChangeLog | 7 +++++++ bfd/coffgen.c | 5 ++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index dea16ae..1b223f9 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2015-02-27 Nick Clifton + + PR binutils/17910 + * coffgen.c (_bfd_coff_internal_syment_name): Only check for + string length overflow when the string table length is actually + set. + 2015-02-27 Marcus Shawcroft * bfd/bfd-in2.h: Regenerate. diff --git a/bfd/coffgen.c b/bfd/coffgen.c index aa01559..83673d4 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -468,7 +468,10 @@ _bfd_coff_internal_syment_name (bfd *abfd, if (strings == NULL) return NULL; } - if (sym->_n._n_n._n_offset >= obj_coff_strings_len (abfd)) + /* PR 17910: Only check for string overflow if the length has been set. + Some DLLs, eg those produced by Visual Studio, may not set the length field. */ + if (obj_coff_strings_len (abfd) > 0 + && sym->_n._n_n._n_offset >= obj_coff_strings_len (abfd)) return NULL; return strings + sym->_n._n_n._n_offset; } -- 2.7.4