From cdb1711fe17a85698dc77076541e534f9e884beb Mon Sep 17 00:00:00 2001 From: deepak1556 Date: Wed, 22 Apr 2015 13:00:10 +0530 Subject: [PATCH] webview: add inspectElement method --- atom/browser/api/atom_api_web_contents.cc | 8 ++++++++ atom/browser/api/atom_api_web_contents.h | 1 + atom/renderer/lib/web-view/web-view.coffee | 1 + docs/api/web-view-tag.md | 7 +++++++ 4 files changed, 17 insertions(+) diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc index 95e99cf..f4a36a8 100644 --- a/atom/browser/api/atom_api_web_contents.cc +++ b/atom/browser/api/atom_api_web_contents.cc @@ -470,6 +470,13 @@ bool WebContents::IsDevToolsOpened() { return storage_->IsDevToolsViewShowing(); } +void WebContents::InspectElement(int x, int y) { + OpenDevTools(); + scoped_refptr agent( + content::DevToolsAgentHost::GetOrCreateFor(storage_->GetWebContents())); + agent->InspectElement(x, y); +} + void WebContents::Undo() { web_contents()->Undo(); } @@ -591,6 +598,7 @@ mate::ObjectTemplateBuilder WebContents::GetObjectTemplateBuilder( .SetMethod("openDevTools", &WebContents::OpenDevTools) .SetMethod("closeDevTools", &WebContents::CloseDevTools) .SetMethod("isDevToolsOpened", &WebContents::IsDevToolsOpened) + .SetMethod("inspectElement", &WebContents::InspectElement) .SetMethod("undo", &WebContents::Undo) .SetMethod("redo", &WebContents::Redo) .SetMethod("cut", &WebContents::Cut) diff --git a/atom/browser/api/atom_api_web_contents.h b/atom/browser/api/atom_api_web_contents.h index 2578c5c..990cbcd 100644 --- a/atom/browser/api/atom_api_web_contents.h +++ b/atom/browser/api/atom_api_web_contents.h @@ -67,6 +67,7 @@ class WebContents : public mate::EventEmitter, void OpenDevTools(); void CloseDevTools(); bool IsDevToolsOpened(); + void InspectElement(int x, int y); // Editing commands. void Undo(); diff --git a/atom/renderer/lib/web-view/web-view.coffee b/atom/renderer/lib/web-view/web-view.coffee index 3058863..bf163c0 100644 --- a/atom/renderer/lib/web-view/web-view.coffee +++ b/atom/renderer/lib/web-view/web-view.coffee @@ -255,6 +255,7 @@ registerWebViewElement = -> "openDevTools" "closeDevTools" "isDevToolsOpened" + "inspectElement" "undo" "redo" "cut" diff --git a/docs/api/web-view-tag.md b/docs/api/web-view-tag.md index f8e5cf8..ec3bd98 100644 --- a/docs/api/web-view-tag.md +++ b/docs/api/web-view-tag.md @@ -219,6 +219,13 @@ Closes the devtools window of guest page. Returns whether guest page has a devtools window attached. +### ``.inspectElement(x, y) + +* `x` Integer +* `y` Integer + +Starts inspecting element at position (`x`, `y`) of guest page. + ### ``.undo() Executes editing command `undo` in page. -- 2.7.4