From cd89c4dbdd3a32749f85cb3ac666b1e9e43e9c0e Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 12 Nov 2020 13:17:16 +0800 Subject: [PATCH] [NFC][coroutines] remove unused argument in SemaCoroutine Test plan: check-llvm, check-clang Reviewers: lxfind, junparser Differential Revision: https://reviews.llvm.org/D91243 --- clang/lib/Sema/SemaCoroutine.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/clang/lib/Sema/SemaCoroutine.cpp b/clang/lib/Sema/SemaCoroutine.cpp index ce4e558..7682061 100644 --- a/clang/lib/Sema/SemaCoroutine.cpp +++ b/clang/lib/Sema/SemaCoroutine.cpp @@ -375,7 +375,7 @@ static ExprResult buildMemberCall(Sema &S, Expr *Base, SourceLocation Loc, // returning await_suspend that results in a guaranteed tail call to the target // coroutine. static Expr *maybeTailCall(Sema &S, QualType RetType, Expr *E, - SourceLocation Loc, bool IsImplicit) { + SourceLocation Loc) { if (RetType->isReferenceType()) return nullptr; Type const *T = RetType.getTypePtr(); @@ -421,8 +421,7 @@ static Expr *maybeTailCall(Sema &S, QualType RetType, Expr *E, /// ExprWithCleanups to clean up the awaiter associated with the co_await /// expression. static ReadySuspendResumeResult buildCoawaitCalls(Sema &S, VarDecl *CoroPromise, - SourceLocation Loc, Expr *E, - bool IsImplicit) { + SourceLocation Loc, Expr *E) { OpaqueValueExpr *Operand = new (S.Context) OpaqueValueExpr(Loc, E->getType(), VK_LValue, E->getObjectKind(), E); @@ -482,7 +481,7 @@ static ReadySuspendResumeResult buildCoawaitCalls(Sema &S, VarDecl *CoroPromise, // Experimental support for coroutine_handle returning await_suspend. if (Expr *TailCallSuspend = - maybeTailCall(S, RetType, AwaitSuspend, Loc, IsImplicit)) + maybeTailCall(S, RetType, AwaitSuspend, Loc)) // Note that we don't wrap the expression with ExprWithCleanups here // because that might interfere with tailcall contract (e.g. inserting // clean up instructions in-between tailcall and return). Instead @@ -907,7 +906,7 @@ ExprResult Sema::BuildResolvedCoawaitExpr(SourceLocation Loc, Expr *E, // Build the await_ready, await_suspend, await_resume calls. ReadySuspendResumeResult RSS = buildCoawaitCalls( - *this, Coroutine->CoroutinePromise, CallLoc, E, IsImplicit); + *this, Coroutine->CoroutinePromise, CallLoc, E); if (RSS.IsInvalid) return ExprError(); @@ -962,7 +961,7 @@ ExprResult Sema::BuildCoyieldExpr(SourceLocation Loc, Expr *E) { // Build the await_ready, await_suspend, await_resume calls. ReadySuspendResumeResult RSS = buildCoawaitCalls( - *this, Coroutine->CoroutinePromise, Loc, E, /*IsImplicit*/ false); + *this, Coroutine->CoroutinePromise, Loc, E); if (RSS.IsInvalid) return ExprError(); -- 2.7.4