From cd71a73d6246dc1b54429804df8da969c73d9656 Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Thu, 27 Aug 2020 01:00:31 -0700 Subject: [PATCH] [clang-tidy] fix inconsistent declarations Found with readability-inconsistent-declaration-parameter-name Signed-off-by: Rosen Penev --- src/evdev-mt-touchpad.h | 2 +- src/evdev-tablet-pad.h | 2 +- src/filter.h | 2 +- src/libinput.h | 2 +- src/quirks.h | 2 +- src/util-ratelimit.h | 2 +- src/util-strings.h | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/evdev-mt-touchpad.h b/src/evdev-mt-touchpad.h index da56926..6ccb122 100644 --- a/src/evdev-mt-touchpad.h +++ b/src/evdev-mt-touchpad.h @@ -640,7 +640,7 @@ tp_button_is_inside_softbutton_area(const struct tp_dispatch *tp, void tp_release_all_taps(struct tp_dispatch *tp, - uint64_t time); + uint64_t now); void tp_tap_suspend(struct tp_dispatch *tp, uint64_t time); diff --git a/src/evdev-tablet-pad.h b/src/evdev-tablet-pad.h index feb9527..3fc0f79 100644 --- a/src/evdev-tablet-pad.h +++ b/src/evdev-tablet-pad.h @@ -103,6 +103,6 @@ void pad_destroy_leds(struct pad_dispatch *pad); void pad_button_update_mode(struct libinput_tablet_pad_mode_group *g, - unsigned int pressed_button, + unsigned int button_index, enum libinput_button_state state); #endif diff --git a/src/filter.h b/src/filter.h index 5c1bdcc..5d4c167 100644 --- a/src/filter.h +++ b/src/filter.h @@ -158,6 +158,6 @@ touchpad_lenovo_x230_accel_profile(struct motion_filter *filter, double trackpoint_accel_profile(struct motion_filter *filter, void *data, - double delta, + double velocity, uint64_t time); #endif /* FILTER_H */ diff --git a/src/libinput.h b/src/libinput.h index 9570648..6f12c66 100644 --- a/src/libinput.h +++ b/src/libinput.h @@ -5061,7 +5061,7 @@ libinput_device_config_accel_get_profiles(struct libinput_device *device); */ enum libinput_config_status libinput_device_config_accel_set_profile(struct libinput_device *device, - enum libinput_config_accel_profile mode); + enum libinput_config_accel_profile profile); /** * @ingroup config diff --git a/src/quirks.h b/src/quirks.h index ee85fe3..db54d9a 100644 --- a/src/quirks.h +++ b/src/quirks.h @@ -118,7 +118,7 @@ enum quirk { * tools, not user consumption. Do not display this in a GUI. */ const char* -quirk_get_name(enum quirk which); +quirk_get_name(enum quirk q); /** * Log priorities used if custom logging is enabled. diff --git a/src/util-ratelimit.h b/src/util-ratelimit.h index a717ae9..5322a00 100644 --- a/src/util-ratelimit.h +++ b/src/util-ratelimit.h @@ -41,5 +41,5 @@ struct ratelimit { unsigned int num; }; -void ratelimit_init(struct ratelimit *r, uint64_t ival_ms, unsigned int burst); +void ratelimit_init(struct ratelimit *r, uint64_t ival_us, unsigned int burst); enum ratelimit_state ratelimit_test(struct ratelimit *r); diff --git a/src/util-strings.h b/src/util-strings.h index 2c31ff8..5d99cfa 100644 --- a/src/util-strings.h +++ b/src/util-strings.h @@ -225,8 +225,8 @@ safe_atod(const char *str, double *val) return true; } -char **strv_from_string(const char *string, const char *separator); -char *strv_join(char **strv, const char *separator); +char **strv_from_string(const char *in, const char *separator); +char *strv_join(char **strv, const char *joiner); static inline void strv_free(char **strv) { -- 2.7.4