From cd71915c7738f0992daefe0320b10e3b1960535c Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Sat, 31 Jan 2015 06:06:38 +0800 Subject: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv(). Or there will be memory leak. 2015-02-02 Chen Gang * mcore/interp.c (sim_do_command): Call freeargv() before return. --- sim/ChangeLog | 4 ++++ sim/mcore/interp.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/sim/ChangeLog b/sim/ChangeLog index 9ddee64..628e6a8 100644 --- a/sim/ChangeLog +++ b/sim/ChangeLog @@ -1,5 +1,9 @@ 2015-02-02 Chen Gang + * mcore/interp.c (sim_do_command): Call freeargv() before return. + +2015-02-02 Chen Gang + * common/sim-options.c (sim_args_command): Call freeargv() when failure occurs. diff --git a/sim/mcore/interp.c b/sim/mcore/interp.c index d2edd12..dfaa6aa 100644 --- a/sim/mcore/interp.c +++ b/sim/mcore/interp.c @@ -2143,6 +2143,7 @@ sim_do_command (sd, cmd) if ((simargv[1] == NULL) || (simargv[2] == NULL)) { fprintf (stderr, "Error: missing argument to watch cmd.\n"); + freeargv (simargv); return; } @@ -2187,6 +2188,8 @@ sim_do_command (sd, cmd) fprintf (stderr,"Error: \"%s\" is not a valid M.CORE simulator command.\n", cmd); } + + freeargv (simargv); } else { -- 2.7.4