From cd6cb94937c27469f1f90990efea5b37c2592ab7 Mon Sep 17 00:00:00 2001 From: Gilbok Lee Date: Wed, 14 Mar 2018 16:55:39 +0900 Subject: [PATCH] Fix coverity issue (Unchecked return value) If sound_manager_start_virtual_stream failed, radio doesn't need to call sound_manager_stop_virtual_stream. [Version] 0.2.34 [Profile] Mobile, Wearable [Issue Type] Fix bugs Change-Id: I279581f1c7b33483f04f3c6afd2c797ec0ed1aea --- packaging/libmm-radio.spec | 2 +- src/mm_radio_priv_hal.c | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packaging/libmm-radio.spec b/packaging/libmm-radio.spec index f7e8b46..9072a22 100755 --- a/packaging/libmm-radio.spec +++ b/packaging/libmm-radio.spec @@ -1,6 +1,6 @@ Name: libmm-radio Summary: Multimedia Framework Radio Library -Version: 0.2.33 +Version: 0.2.34 Release: 0 Group: System/Libraries License: Apache-2.0 diff --git a/src/mm_radio_priv_hal.c b/src/mm_radio_priv_hal.c index 511c74b..1e7bb92 100755 --- a/src/mm_radio_priv_hal.c +++ b/src/mm_radio_priv_hal.c @@ -647,7 +647,7 @@ int _mmradio_start(mm_radio_t *radio) ret = sound_manager_start_virtual_stream(radio->vstream); if (ret) { MMRADIO_LOG_ERROR("failed to start sound manager virtual stream"); - goto error; + goto error1; } #endif @@ -657,10 +657,6 @@ int _mmradio_start(mm_radio_t *radio) return MM_ERROR_NONE; -#ifdef TIZEN_FEATURE_SOUND_VSTREAM -error: - sound_manager_stop_virtual_stream(radio->vstream); -#endif error1: radio_hal_close(radio->hal_inf); error2: -- 2.7.4