From cd650ab9a88b73cd43645d6a71294d3c2bf96700 Mon Sep 17 00:00:00 2001 From: Jaehwan Kim Date: Fri, 15 Oct 2010 18:01:14 +0900 Subject: [PATCH] svn merge 51950 --- src/lib/ecore/ecore_thread.c | 2 +- src/lib/ecore_x/xlib/ecore_x_window.c | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/lib/ecore/ecore_thread.c b/src/lib/ecore/ecore_thread.c index 4bcd82e..bfc8af7 100644 --- a/src/lib/ecore/ecore_thread.c +++ b/src/lib/ecore/ecore_thread.c @@ -627,7 +627,7 @@ EAPI Ecore_Thread *ecore_long_run(Ecore_Thread_Heavy_Cb func_heavy, if (!pth) goto on_error; pth->p = ecore_pipe_add(_ecore_thread_handler, NULL); - if (pth->p) goto on_error; + if (!pth->p) goto on_error; if (pthread_create(&pth->thread, NULL, (void *) _ecore_thread_worker, pth) == 0) return (Ecore_Thread *) worker; diff --git a/src/lib/ecore_x/xlib/ecore_x_window.c b/src/lib/ecore_x/xlib/ecore_x_window.c index 1628564..8308c3f 100644 --- a/src/lib/ecore_x/xlib/ecore_x_window.c +++ b/src/lib/ecore_x/xlib/ecore_x_window.c @@ -657,6 +657,13 @@ ecore_x_window_size_get(Ecore_X_Window win, int *w, int *h) /** * Retrieves the geometry of the given window. + * + * Note that the x & y coordingates are relative to your parent. In + * particular for reparenting window managers - relative to you window border. + * If you want screen coordinates either walk the window tree to the root, + * else for ecore_evas applications see ecore_evas_geometry_get(). Elementary + * applications can use elm_win_screen_position_get(). + * * @param win The given window. * @param x Pointer to an integer in which the X position is to be stored. * @param y Pointer to an integer in which the Y position is to be stored. -- 2.7.4