From cd12e79e6ddd235739716fff5c6a748915f664b9 Mon Sep 17 00:00:00 2001 From: Jean-Michel Gorius Date: Mon, 18 May 2020 21:30:43 +0200 Subject: [PATCH] [x86] Propagate memory operands during ISel DAG postprocessing Summary: Propagate memory operands when folding test instructions. This was split from D80062. Reviewers: craig.topper, rnk, lebedev.ri Reviewed By: craig.topper Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D80140 --- llvm/lib/Target/X86/X86ISelDAGToDAG.cpp | 2 ++ .../CodeGen/X86/isel-postprocessing-test-fold-memop.ll | 14 ++++++++++++++ 2 files changed, 16 insertions(+) create mode 100644 llvm/test/CodeGen/X86/isel-postprocessing-test-fold-memop.ll diff --git a/llvm/lib/Target/X86/X86ISelDAGToDAG.cpp b/llvm/lib/Target/X86/X86ISelDAGToDAG.cpp index ab816ec..ffe9d43 100644 --- a/llvm/lib/Target/X86/X86ISelDAGToDAG.cpp +++ b/llvm/lib/Target/X86/X86ISelDAGToDAG.cpp @@ -1388,6 +1388,8 @@ void X86DAGToDAGISel::PostprocessISelDAG() { And.getOperand(6) /* Chain */ }; MachineSDNode *Test = CurDAG->getMachineNode(NewOpc, SDLoc(N), MVT::i32, MVT::Other, Ops); + CurDAG->setNodeMemRefs( + Test, cast(And.getNode())->memoperands()); ReplaceUses(N, Test); MadeChange = true; continue; diff --git a/llvm/test/CodeGen/X86/isel-postprocessing-test-fold-memop.ll b/llvm/test/CodeGen/X86/isel-postprocessing-test-fold-memop.ll new file mode 100644 index 0000000..99a80fa --- /dev/null +++ b/llvm/test/CodeGen/X86/isel-postprocessing-test-fold-memop.ll @@ -0,0 +1,14 @@ +; RUN: llc -O2 -mtriple=x86_64-- -stop-after=finalize-isel < %s | FileCheck %s + +define i1 @fold_test(i64* %x, i64 %l) { +entry: + %0 = load i64, i64* %x, align 8 + %and = and i64 %0, %l + %tobool = icmp ne i64 %and, 0 + ret i1 %tobool + + ; Folding the load+and+icmp instructions into a TEST64mr instruction + ; should preserve memory operands. + ; CHECK: TEST64mr {{.*}} :: (load 8 from {{%.*}}) +} + -- 2.7.4