From cd1175a373590f053bea8aa9f2dfaeae13906aa9 Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Thu, 3 Jul 2014 08:45:57 -0700 Subject: [PATCH] alpha: Remove round and roundf implementations Two bugs in these implementations: First is that the add of 0.5 was not done in chopped rounding mode (easily fixable). Second is that the method generates incorrect inexact exceptions for small integral values (not easily fixable). --- ChangeLog | 3 +++ sysdeps/alpha/fpu/s_round.c | 48 -------------------------------------------- sysdeps/alpha/fpu/s_roundf.c | 43 --------------------------------------- 3 files changed, 3 insertions(+), 91 deletions(-) delete mode 100644 sysdeps/alpha/fpu/s_round.c delete mode 100644 sysdeps/alpha/fpu/s_roundf.c diff --git a/ChangeLog b/ChangeLog index 9170174..87b7a93 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2014-07-03 Richard Henderson + * sysdeps/alpha/fpu/s_round.c: Remove file. + * sysdeps/alpha/fpu/s_roundf.c: Remove file. + * elf/dl-support.c (HP_TIMING_AVAIL): Do not redefine. (_dl_non_dynamic_init): Check HP_SMALL_TIMING_AVAIL instead. * elf/rtld.c (HP_TIMING_AVAIL): Do not redefine. diff --git a/sysdeps/alpha/fpu/s_round.c b/sysdeps/alpha/fpu/s_round.c deleted file mode 100644 index 62a8e72..0000000 --- a/sysdeps/alpha/fpu/s_round.c +++ /dev/null @@ -1,48 +0,0 @@ -/* Copyright (C) 2007-2014 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - . */ - -#include -#include - - -double -__round (double x) -{ - const double almost_half = 0x1.fffffffffffffp-2; - const double two52 = 0x1.0p52; - double tmp, r; - - __asm ( -#ifdef _IEEE_FP_INEXACT - "addt/suic %2, %3, %1\n\tsubt/suic %1, %3, %0" -#else - "addt/suc %2, %3, %1\n\tsubt/suc %1, %3, %0" -#endif - : "=&f"(r), "=&f"(tmp) - : "f"(fabs (x) + almost_half), "f"(two52)); - - return copysign (r, x); -} - -weak_alias (__round, round) -#ifdef NO_LONG_DOUBLE -strong_alias (__round, __roundl) -weak_alias (__roundl, roundl) -#endif -#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_1) -compat_symbol (libm, __round, roundl, GLIBC_2_1); -#endif diff --git a/sysdeps/alpha/fpu/s_roundf.c b/sysdeps/alpha/fpu/s_roundf.c deleted file mode 100644 index a07ffa3..0000000 --- a/sysdeps/alpha/fpu/s_roundf.c +++ /dev/null @@ -1,43 +0,0 @@ -/* Copyright (C) 2007-2014 Free Software Foundation, Inc. - This file is part of the GNU C Library. - Contributed by Richard Henderson. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - . */ - -#include - - -float -__roundf (float x) -{ - const float almost_half = 0x1.fffffep-2; - const float two23 = 0x1.0p23; - float r, tmp; - - __asm ( -#ifdef _IEEE_FP_INEXACT - "adds/suic %2, %3, %1\n\tsubs/suic %1, %3, %0" -#else - "adds/suc %2, %3, %1\n\tsubs/suc %1, %3, %0" -#endif - : "=&f"(r), "=&f"(tmp) - : "f"(fabsf (x) + almost_half), "f"(two23)); - - /* round(-0) == -0, and in general we'll always have the same - sign as our input. */ - return copysignf (r, x); -} - -weak_alias (__roundf, roundf) -- 2.7.4