From ccdac490bb3b568e88626afc84017c79e2d086e7 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 20 May 2018 16:15:14 -0600 Subject: [PATCH] Use gdb_assert in two places in buildsym.c This changes buildsym.c to use gdb_assert rather than internal_error in a couple of spots. gdb/ChangeLog 2018-07-16 Tom Tromey * buildsym.c (push_subfile): Use gdb_assert. (pop_subfile): Use gdb_assert. --- gdb/ChangeLog | 5 +++++ gdb/buildsym.c | 12 ++---------- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 04b80eb..d382384 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2018-07-16 Tom Tromey + * buildsym.c (push_subfile): Use gdb_assert. + (pop_subfile): Use gdb_assert. + +2018-07-16 Tom Tromey + * buildsym.h (merge_symbol_lists): Remove. * buildsym.c (merge_symbol_lists): Remove. diff --git a/gdb/buildsym.c b/gdb/buildsym.c index d1e47c3..6db07ce 100644 --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -891,11 +891,7 @@ push_subfile (void) tem->next = subfile_stack; subfile_stack = tem; - if (current_subfile == NULL || current_subfile->name == NULL) - { - internal_error (__FILE__, __LINE__, - _("failed internal consistency check")); - } + gdb_assert (current_subfile != NULL && current_subfile->name != NULL); tem->name = current_subfile->name; } @@ -905,11 +901,7 @@ pop_subfile (void) char *name; struct subfile_stack *link = subfile_stack; - if (link == NULL) - { - internal_error (__FILE__, __LINE__, - _("failed internal consistency check")); - } + gdb_assert (link != NULL); name = link->name; subfile_stack = link->next; xfree ((void *) link); -- 2.7.4