From cc5418461910dc775249e87091b2c6a3ea8d2cd3 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Mon, 28 Nov 2022 10:14:16 +0100 Subject: [PATCH] lib: simplify fdt_parse_plicsw_node() We should not check !plicsw_base || !size twice. Signed-off-by: Heinrich Schuchardt Reviewed-by: Xiang W Reviewed-by: Yu Chien Peter Lin Reviewed-by: Bin Meng --- lib/utils/fdt/fdt_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c index dbd7484..87b9fb2 100644 --- a/lib/utils/fdt/fdt_helper.c +++ b/lib/utils/fdt/fdt_helper.c @@ -868,7 +868,7 @@ int fdt_parse_plicsw_node(void *fdt, int nodeoffset, unsigned long *plicsw_base, rc = fdt_get_node_addr_size(fdt, nodeoffset, 0, ®_addr, ®_size); - if (rc < 0 || !plicsw_base || !size) + if (rc < 0) return SBI_ENODEV; *plicsw_base = reg_addr; *size = reg_size; -- 2.7.4