From cbed6e5b2ff026e4d64de8f6ee19bc902b6e0e23 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 12 May 2021 12:26:00 -0400 Subject: [PATCH] [SystemZ][z/OS] Fix warning caused by umask returning a signed integer type On z/OS, umask() returns an int because mode_t is type int, however it is being compared to an unsigned int. This patch fixes the following warning we see when compiling Path.cpp. ``` comparison of integers of different signs: 'const int' and 'const unsigned int' ``` Reviewed By: muiez Differential Revision: https://reviews.llvm.org/D102326 --- llvm/unittests/Support/Path.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/llvm/unittests/Support/Path.cpp b/llvm/unittests/Support/Path.cpp index 33f2c71..7f95e6c 100644 --- a/llvm/unittests/Support/Path.cpp +++ b/llvm/unittests/Support/Path.cpp @@ -1933,7 +1933,8 @@ TEST_F(FileSystemTest, getUmask) { unsigned CurrentMask = fs::getUmask(); EXPECT_EQ(CurrentMask, 0022U) << "getUmask() didn't return previously set umask()"; - EXPECT_EQ(::umask(OldMask), 0022U) << "getUmask() may have changed umask()"; + EXPECT_EQ(::umask(OldMask), mode_t(0022U)) + << "getUmask() may have changed umask()"; #endif } -- 2.7.4