From cba3e8b4b5d471acda77cb1d5df4c158365b0788 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Tue, 29 Mar 2016 18:18:19 +0000 Subject: [PATCH] Change how we handle R_MIPS_LO16. Mips aligns PT_LOAD to 16 bits (0x10000). That means that the lower 16 bits are always the same, so we can, effectively, say that the relocation is relative. llvm-svn: 264761 --- lld/ELF/Target.cpp | 1 - lld/ELF/Writer.cpp | 9 --------- 2 files changed, 10 deletions(-) diff --git a/lld/ELF/Target.cpp b/lld/ELF/Target.cpp index 4f87aac..998ad4f 100644 --- a/lld/ELF/Target.cpp +++ b/lld/ELF/Target.cpp @@ -1819,7 +1819,6 @@ bool MipsTargetInfo::isRelRelative(uint32_t Type) const { case R_MIPS_32: case R_MIPS_64: case R_MIPS_HI16: - case R_MIPS_LO16: case R_MIPS_TLS_DTPREL_HI16: case R_MIPS_TLS_DTPREL_LO16: case R_MIPS_TLS_TPREL_HI16: diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp index 2048a8e..4e24588 100644 --- a/lld/ELF/Writer.cpp +++ b/lld/ELF/Writer.cpp @@ -432,15 +432,6 @@ void Writer::scanRelocs(InputSectionBase &C, } if (Config->EMachine == EM_MIPS) { - if (Type == R_MIPS_LO16) - // Ignore R_MIPS_LO16 relocation. If it is a pair for R_MIPS_GOT16 we - // already completed all required action (GOT entry allocation) when - // handle R_MIPS_GOT16a. If it is a pair for R_MIPS_HI16 against - // _gp_disp it does not require dynamic relocation. If its a pair for - // R_MIPS_HI16 against a regular symbol it does not require dynamic - // relocation too because that case is possible for executable file - // linking only. - continue; if (&Body == Config->MipsGpDisp || &Body == Config->MipsLocalGp) // MIPS _gp_disp designates offset between start of function and 'gp' // pointer into GOT. __gnu_local_gp is equal to the current value of -- 2.7.4