From cb986062fc82b459cc51f92436c6a53cf032c3d5 Mon Sep 17 00:00:00 2001
From: Dongju Chae <dongju.chae@samsung.com>
Date: Mon, 3 Feb 2020 20:36:04 +0900
Subject: [PATCH] [TestCoverage/Fix] Generate test coverage results in gcc-9
 env.

This commit generates test coverage results in gcc-9 env.
But, it requires the latest version of lcov, and some perl modules.
So, this should be done only in CI servers that can hold cached rpm
files.

Signed-off-by: Dongju Chae <dongju.chae@samsung.com>
---
 packaging/nnstreamer.spec |  1 +
 tests/unittestcoverage.py | 39 +++++++++++++++++++--------------------
 2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/packaging/nnstreamer.spec b/packaging/nnstreamer.spec
index 1b24313..6f0272b 100644
--- a/packaging/nnstreamer.spec
+++ b/packaging/nnstreamer.spec
@@ -85,6 +85,7 @@ BuildRequires:	pkgconfig(edgetpu)
 %endif
 
 %if 0%{?testcoverage}
+# to be compatible with gcc-9, lcov should have a higher version than 1.14.1
 BuildRequires: lcov
 # BuildRequires:	taos-ci-unittest-coverage-assessment
 %endif
diff --git a/tests/unittestcoverage.py b/tests/unittestcoverage.py
index 2f20f54..5a77c43 100755
--- a/tests/unittestcoverage.py
+++ b/tests/unittestcoverage.py
@@ -194,25 +194,24 @@ def check_component(path):
   out = os.popen("gcov -p -r -s " + path + " `find " + buildpath +
                  " -name *.gcno`").read()
   dprint(out)
-  endpoint = len(out) - 1
-  while (out[endpoint] == '\n'):
-    endpoint = endpoint - 1
-  startpoint = endpoint
-  endpoint = endpoint + 1
-  while (out[startpoint] != '\n' and startpoint >= 0):
-    startpoint = startpoint - 1
-  startpoint = startpoint + 1
-
-  lastline = out[startpoint:endpoint]
-  m = re.match("Lines executed:(\d+.\d+)% of (\d+)$", lastline)
-  if m:
-    rate = float(m.group(1))
-    lines = int(m.group(2))
-  else:
-    print("ERROR! Cannot parse gcov result!")
-    return (-1, -1)
-
-  return (lines, rate)
+
+  total_lines = 0
+  total_covered = 0
+  total_rate = 0.0
+  # Calculate a line coverage per file
+  for each_line in out.splitlines():
+    m = re.match("Lines executed:(\d+.\d+)% of (\d+)$", each_line)
+    if m:
+      rate = float(m.group(1))
+      lines = int(m.group(2))
+
+      total_lines = total_lines + lines
+      total_covered = total_covered + (rate * lines)
+
+  if total_lines > 0:
+    total_rate = total_covered / total_lines
+
+  return (total_lines, total_rate)
   # Call auditEvaders(out, path) if we really become paranoid.
 
 ## @brief Check unit test coverage for a specific path. (every code in that path, recursively)
@@ -234,7 +233,7 @@ def cmd_module(paths):
 
   print("\n\n===========================================================")
   print("Paths for test coverage " + str(paths))
-  print(str(lines) + " Lines with " + str(rate) + "% unit test coverage")
+  print("%d Lines with %0.2f%% unit test coverage" % (lines, rate))
   print("===========================================================\n\n\n")
   return 0
 
-- 
2.7.4