From cb0ee0994c7c2ae24dbe6207675ea9ec0654f0d6 Mon Sep 17 00:00:00 2001 From: "rniwa@webkit.org" Date: Tue, 17 Apr 2012 07:18:44 +0000 Subject: [PATCH] Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot https://bugs.webkit.org/show_bug.cgi?id=84068 Reviewed by Eric Seidel. Remove CreateWebKitBuildDirectory from master.cfg since download-built-product automatically creates the build directory if needed. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (DownloadAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit2Factory.__init__): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114353 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg | 11 ----------- Tools/ChangeLog | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg b/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg index 58093ee..feb72ae 100644 --- a/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg +++ b/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg @@ -244,15 +244,6 @@ class DownloadBuiltProduct(shell.ShellCommand): flunkOnFailure = True -class CreateWebKitBuildDirectory(shell.ShellCommand): - command = ["mkdir", "-p", "WebKitBuild"] - name = "create-webkitbuild-dir" - description = ["creating WebKitBuild directory"] - descriptionDone = ["created WebKitBuild directory"] - haltOnFailure = True - flunkOnFailure = True - - class RunJavaScriptCoreTests(shell.Test): name = "jscore-test" description = ["jscore-tests running"] @@ -827,7 +818,6 @@ class BuildAndPerfTestWebKit2Factory(Factory): class DownloadAndPerfTestFactory(Factory): def __init__(self, platform, configuration, architectures, **kwargs): Factory.__init__(self, platform, configuration, architectures, False, **kwargs) - self.addStep(CreateWebKitBuildDirectory) self.addStep(DownloadBuiltProduct) self.addStep(ExtractBuiltProduct) self.addStep(RunAndUploadPerfTests) @@ -835,7 +825,6 @@ class DownloadAndPerfTestFactory(Factory): class DownloadAndPerfTestWebKit2Factory(Factory): def __init__(self, platform, configuration, architectures, **kwargs): Factory.__init__(self, platform, configuration, architectures, False, **kwargs) - self.addStep(CreateWebKitBuildDirectory) self.addStep(DownloadBuiltProduct) self.addStep(ExtractBuiltProduct) self.addStep(RunAndUploadPerfTestsWebKit2) diff --git a/Tools/ChangeLog b/Tools/ChangeLog index 22276be..37ef7bd 100644 --- a/Tools/ChangeLog +++ b/Tools/ChangeLog @@ -1,3 +1,17 @@ +2012-04-16 Ryosuke Niwa + + Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot + https://bugs.webkit.org/show_bug.cgi?id=84068 + + Reviewed by Eric Seidel. + + Remove CreateWebKitBuildDirectory from master.cfg since download-built-product + automatically creates the build directory if needed. + + * BuildSlaveSupport/build.webkit.org-config/master.cfg: + (DownloadAndPerfTestFactory.__init__): + (DownloadAndPerfTestWebKit2Factory.__init__): + 2012-04-16 Gustavo Noronha Silva [GTK] Use configure instead of autogen.sh for gtk+ -- 2.7.4