From caad2170aed76d1df8b4305b1b7d81c4943626db Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 31 Oct 2019 13:39:48 -0700 Subject: [PATCH] [cmake] Remove SVN support from VersionFromVCS.cmake Reviewers: phosek Subscribers: mgorny, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D69682 --- llvm/CMakeLists.txt | 6 +- llvm/cmake/modules/VersionFromVCS.cmake | 103 +++++++++----------------------- 2 files changed, 30 insertions(+), 79 deletions(-) diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt index ec9050b..ad10ca2 100644 --- a/llvm/CMakeLists.txt +++ b/llvm/CMakeLists.txt @@ -805,11 +805,7 @@ set(LLVM_SRPM_DIR "${CMAKE_CURRENT_BINARY_DIR}/srpm") get_source_info(${CMAKE_CURRENT_SOURCE_DIR} revision repository) string(LENGTH "${revision}" revision_length) -if(revision MATCHES "^[0-9]+$" AND revision_length LESS 40) - set(LLVM_RPM_SPEC_REVISION "r${revision}") -else() - set(LLVM_RPM_SPEC_REVISION "${revision}") -endif() +set(LLVM_RPM_SPEC_REVISION "${revision}") configure_file( ${LLVM_SRPM_USER_BINARY_SPECFILE} diff --git a/llvm/cmake/modules/VersionFromVCS.cmake b/llvm/cmake/modules/VersionFromVCS.cmake index 56331a3..1b6519b 100644 --- a/llvm/cmake/modules/VersionFromVCS.cmake +++ b/llvm/cmake/modules/VersionFromVCS.cmake @@ -3,27 +3,7 @@ # existence of certain subdirectories under SOURCE_DIR (if provided as an # extra argument, otherwise uses CMAKE_CURRENT_SOURCE_DIR). -function(get_source_info_svn path revision repository) - # If svn is a bat file, find_program(Subversion) doesn't find it. - # Explicitly search for that here; Subversion_SVN_EXECUTABLE will override - # the find_program call in FindSubversion.cmake. - find_program(Subversion_SVN_EXECUTABLE NAMES svn svn.bat) - find_package(Subversion) - - # Subversion module does not work with symlinks, see PR8437. - get_filename_component(realpath ${path} REALPATH) - if(Subversion_FOUND) - subversion_wc_info(${realpath} Project) - if(Project_WC_REVISION) - set(${revision} ${Project_WC_REVISION} PARENT_SCOPE) - endif() - if(Project_WC_URL) - set(${repository} ${Project_WC_URL} PARENT_SCOPE) - endif() - endif() -endfunction() - -function(get_source_info_git path revision repository) +function(get_source_info path revision repository) find_package(Git) if(GIT_FOUND) execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse --git-dir @@ -34,61 +14,36 @@ function(get_source_info_git path revision repository) if(git_result EQUAL 0) string(STRIP "${git_output}" git_output) get_filename_component(git_dir ${git_output} ABSOLUTE BASE_DIR ${path}) - if(EXISTS "${git_dir}/svn/refs") - execute_process(COMMAND ${GIT_EXECUTABLE} svn info - WORKING_DIRECTORY ${path} - RESULT_VARIABLE git_result - OUTPUT_VARIABLE git_output) - if(git_result EQUAL 0) - string(REGEX REPLACE "^(.*\n)?Revision: ([^\n]+).*" - "\\2" git_svn_rev "${git_output}") - set(${revision} ${git_svn_rev} PARENT_SCOPE) - string(REGEX REPLACE "^(.*\n)?URL: ([^\n]+).*" - "\\2" git_url "${git_output}") - set(${repository} ${git_url} PARENT_SCOPE) - endif() + execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse HEAD + WORKING_DIRECTORY ${path} + RESULT_VARIABLE git_result + OUTPUT_VARIABLE git_output) + if(git_result EQUAL 0) + string(STRIP "${git_output}" git_output) + set(${revision} ${git_output} PARENT_SCOPE) + endif() + execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse --abbrev-ref --symbolic-full-name @{upstream} + WORKING_DIRECTORY ${path} + RESULT_VARIABLE git_result + OUTPUT_VARIABLE git_output + ERROR_QUIET) + if(git_result EQUAL 0) + string(REPLACE "/" ";" branch ${git_output}) + list(GET branch 0 remote) + else() + set(remote "origin") + endif() + execute_process(COMMAND ${GIT_EXECUTABLE} remote get-url ${remote} + WORKING_DIRECTORY ${path} + RESULT_VARIABLE git_result + OUTPUT_VARIABLE git_output + ERROR_QUIET) + if(git_result EQUAL 0) + string(STRIP "${git_output}" git_output) + set(${repository} ${git_output} PARENT_SCOPE) else() - execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse HEAD - WORKING_DIRECTORY ${path} - RESULT_VARIABLE git_result - OUTPUT_VARIABLE git_output) - if(git_result EQUAL 0) - string(STRIP "${git_output}" git_output) - set(${revision} ${git_output} PARENT_SCOPE) - endif() - execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse --abbrev-ref --symbolic-full-name @{upstream} - WORKING_DIRECTORY ${path} - RESULT_VARIABLE git_result - OUTPUT_VARIABLE git_output - ERROR_QUIET) - if(git_result EQUAL 0) - string(REPLACE "/" ";" branch ${git_output}) - list(GET branch 0 remote) - else() - set(remote "origin") - endif() - execute_process(COMMAND ${GIT_EXECUTABLE} remote get-url ${remote} - WORKING_DIRECTORY ${path} - RESULT_VARIABLE git_result - OUTPUT_VARIABLE git_output - ERROR_QUIET) - if(git_result EQUAL 0) - string(STRIP "${git_output}" git_output) - set(${repository} ${git_output} PARENT_SCOPE) - else() - set(${repository} ${path} PARENT_SCOPE) - endif() + set(${repository} ${path} PARENT_SCOPE) endif() endif() endif() endfunction() - -function(get_source_info path revision repository) - if(EXISTS "${path}/.svn") - get_source_info_svn("${path}" revision_info repository_info) - else() - get_source_info_git("${path}" revision_info repository_info) - endif() - set(${repository} "${repository_info}" PARENT_SCOPE) - set(${revision} "${revision_info}" PARENT_SCOPE) -endfunction() -- 2.7.4