From ca9c3174b9aecbbeaf0df1f6bcce230fdcfba2ad Mon Sep 17 00:00:00 2001 From: Mateusz Moscicki Date: Mon, 21 Oct 2019 15:04:09 +0200 Subject: [PATCH] Release 5.5.25: Converity fix This release brings: - Add check if sh_entsize is zero (coverity fix) - Ensure child termination is handled properly in crash-service Change-Id: I91f400d1e747fbd84894d77b6f215fb5efc03635 --- packaging/crash-worker.spec | 2 +- packaging/crash-worker_system-tests.spec | 2 +- src/livedumper/core.hpp | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packaging/crash-worker.spec b/packaging/crash-worker.spec index 6ca15f7..e4d58a0 100644 --- a/packaging/crash-worker.spec +++ b/packaging/crash-worker.spec @@ -13,7 +13,7 @@ Name: crash-worker Summary: Crash-manager -Version: 5.5.24 +Version: 5.5.25 Release: 1 Group: Framework/system License: Apache-2.0 and BSD diff --git a/packaging/crash-worker_system-tests.spec b/packaging/crash-worker_system-tests.spec index e8a56b3..163c147 100644 --- a/packaging/crash-worker_system-tests.spec +++ b/packaging/crash-worker_system-tests.spec @@ -8,7 +8,7 @@ Name: crash-worker_system-tests Summary: Package with binaries and scripts for crash-worker system tests -Version: 5.5.24 +Version: 5.5.25 Release: 1 Group: Framework/system License: Apache-2.0 and BSD diff --git a/src/livedumper/core.hpp b/src/livedumper/core.hpp index 54bcf9b..2e4a8c4 100644 --- a/src/livedumper/core.hpp +++ b/src/livedumper/core.hpp @@ -306,6 +306,10 @@ class Core { } sym_data->data = elf_getdata(scn, nullptr); + if (sym_data->shdr.sh_entsize == 0) { + logger.log_info("sh_entsize is zero for %s", lib.c_str()); + return nullptr; + } sym_data->count = sym_data->shdr.sh_size / sym_data->shdr.sh_entsize; return sym_data; -- 2.7.4