From ca4b95069ca7dbf0be3a5aae053631e7a1b20103 Mon Sep 17 00:00:00 2001 From: Marek Polacek Date: Thu, 26 May 2022 18:59:44 -0400 Subject: [PATCH] c-family: fix attribute constructor ICE [PR90658] Here the C compiler crashes because a FUNCTION_DECL got into get_priority -> default_conversion, and the C FE's version of d_c specifically asserts that it doesn't get a FUNCTION_DECL. All uses of default_conversion in c-attribs.cc are guarded by != IDENTIFIER_NODE && != FUNCTION_DECL, but get_priority was only checking IDENTIFIER_NODE. PR c/90658 gcc/c-family/ChangeLog: * c-attribs.cc (get_priority): Check FUNCTION_DECL. gcc/testsuite/ChangeLog: * c-c++-common/attr-cdtor-1.c: New test. --- gcc/c-family/c-attribs.cc | 2 +- gcc/testsuite/c-c++-common/attr-cdtor-1.c | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/c-c++-common/attr-cdtor-1.c diff --git a/gcc/c-family/c-attribs.cc b/gcc/c-family/c-attribs.cc index 4dc68db..c8d9672 100644 --- a/gcc/c-family/c-attribs.cc +++ b/gcc/c-family/c-attribs.cc @@ -1895,7 +1895,7 @@ get_priority (tree args, bool is_destructor) } arg = TREE_VALUE (args); - if (TREE_CODE (arg) == IDENTIFIER_NODE) + if (TREE_CODE (arg) == IDENTIFIER_NODE || TREE_CODE (arg) == FUNCTION_DECL) goto invalid; if (arg == error_mark_node) return DEFAULT_INIT_PRIORITY; diff --git a/gcc/testsuite/c-c++-common/attr-cdtor-1.c b/gcc/testsuite/c-c++-common/attr-cdtor-1.c new file mode 100644 index 0000000..ea61336 --- /dev/null +++ b/gcc/testsuite/c-c++-common/attr-cdtor-1.c @@ -0,0 +1,6 @@ +/* PR c/90658 */ +/* { dg-do compile } */ + +void f (); +void g1 () __attribute__ ((constructor(f))); /* { dg-error "priorities must be integers" } */ +void g2 () __attribute__ ((destructor(f))); /* { dg-error "priorities must be integers" } */ -- 2.7.4