From c9e80a7fabcf3757edd92e17ebad4189f4abb186 Mon Sep 17 00:00:00 2001 From: Santiago Fernandez Madero Date: Tue, 16 Jan 2018 13:53:23 -0800 Subject: [PATCH] Update corelib shared README.md (dotnet/corefx#26366) Signed-off-by: dotnet-bot-corefx-mirror --- src/mscorlib/shared/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mscorlib/shared/README.md b/src/mscorlib/shared/README.md index d55f325..beda969 100644 --- a/src/mscorlib/shared/README.md +++ b/src/mscorlib/shared/README.md @@ -1,12 +1,12 @@ # System.Private.CoreLib Shared Sources -This directory contains the shared sources for System.Private.CoreLib. These are shared between [dotnet/corert](https://github.com/dotnet/corert/tree/master/src/System.Private.CoreLib/shared) and [dotnet/coreclr](https://github.com/dotnet/coreclr/tree/master/src/mscorlib/shared). +This directory contains the shared sources for System.Private.CoreLib. These are shared between [dotnet/corert](https://github.com/dotnet/corert/tree/master/src/System.Private.CoreLib/shared), [dotnet/coreclr](https://github.com/dotnet/coreclr/tree/master/src/mscorlib/shared) and [dotnet/corefx](https://github.com/dotnet/corefx/tree/master/src/Common/src/CoreLib). The sources are synchronized with a mirroring tool that watches for new commits on either side and creates new pull requests (as @dotnet-bot) in the other repository. ## Conventions -Code in the shared directory should have no code specific to CoreCLR or CoreRT. Parts of classes that need to have different implementations on different runtimes should use partial classes and *.CoreRT.cs/*.CoreCLR.cs files in the non shared portion. Code that is different based on platform (Windows/Unix) is fine to leave in the shared portion. Remember to follow the [style guidelines](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md). +Code in the shared directory should have no code specific to CoreCLR, CoreRT or CoreFX. Parts of classes that need to have different implementations on different runtimes should use partial classes and *.CoreRT.cs/*.CoreCLR.cs/*.CoreFX.cs files in the non shared portion. Code that is different based on platform (Windows/Unix) is fine to leave in the shared portion. Remember to follow the [style guidelines](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md). ## Getting clean CI and merging the mirror PRs -- 2.7.4