From c95f9494fe67feaccfbb33f7d066f21427ce8ed6 Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Tue, 15 Feb 2011 12:46:10 +0100 Subject: [PATCH] re PR middle-end/47581 (Unnecessary adjustments to stack pointer) PR middle-end/47581 * config/i386/i386.c (ix86_compute_frame_size): Don't align offset if frame size is 0 in a leaf function. * gcc.target/i386/pr47581.c: New test. From-SVN: r170170 --- gcc/ChangeLog | 6 ++++++ gcc/config/i386/i386.c | 8 +++++++- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.target/i386/pr47581.c | 10 ++++++++++ 4 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr47581.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 32d9649..3b325da 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2011-02-15 Jakub Jelinek + + PR middle-end/47581 + * config/i386/i386.c (ix86_compute_frame_size): Don't align offset + if frame size is 0 in a leaf function. + 2011-02-15 Rainer Orth PR pch/14940 diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 12c7062..9956366 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -9307,7 +9307,13 @@ ix86_compute_frame_layout (struct ix86_frame *frame) offset += frame->va_arg_size; /* Align start of frame for local function. */ - offset = (offset + stack_alignment_needed - 1) & -stack_alignment_needed; + if (stack_realign_fp + || offset != frame->sse_reg_save_offset + || size != 0 + || !current_function_is_leaf + || cfun->calls_alloca + || ix86_current_function_calls_tls_descriptor) + offset = (offset + stack_alignment_needed - 1) & -stack_alignment_needed; /* Frame pointer points here. */ frame->frame_pointer_offset = offset; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 866010a..1c15f63 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2011-02-15 Jakub Jelinek + + PR middle-end/47581 + * gcc.target/i386/pr47581.c: New test. + 2011-02-14 Janus Weil PR fortran/47730 diff --git a/gcc/testsuite/gcc.target/i386/pr47581.c b/gcc/testsuite/gcc.target/i386/pr47581.c new file mode 100644 index 0000000..dfc02a1 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr47581.c @@ -0,0 +1,10 @@ +/* PR middle-end/47581 */ +/* { dg-do compile } */ +/* { dg-options "-O2 -fomit-frame-pointer -mpreferred-stack-boundary=4 -mincoming-stack-boundary=4" } */ +/* { dg-final { scan-assembler-not "(sub|add)l\[\\t \]*\\$\[0-9\]*,\[\\t \]*%\[re\]?sp" } } */ + +unsigned +foo (unsigned a, unsigned b) +{ + return ((unsigned long long) a * (unsigned long long) b) >> 32; +} -- 2.7.4