From c9436088585c3ad8a9736d5c096e0927c467a660 Mon Sep 17 00:00:00 2001 From: Xing GUO Date: Sat, 1 Dec 2018 12:27:24 +0000 Subject: [PATCH] [llvm-readobj] Improve dynamic section iteration NFC. llvm-svn: 348074 --- llvm/tools/llvm-readobj/ELFDumper.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp index ea0bb73..557acd3 100644 --- a/llvm/tools/llvm-readobj/ELFDumper.cpp +++ b/llvm/tools/llvm-readobj/ELFDumper.cpp @@ -639,9 +639,12 @@ static void printVersionDefinitionSection(ELFDumper *Dumper, // is determined by DT_VERDEFNUM tag. unsigned VerDefsNum = 0; for (const typename ELFO::Elf_Dyn &Dyn : Dumper->dynamic_table()) { - if (Dyn.d_tag == DT_VERDEFNUM) + if (Dyn.d_tag == DT_VERDEFNUM) { VerDefsNum = Dyn.d_un.d_val; + break; + } } + const uint8_t *SecStartAddress = (const uint8_t *)Obj->base() + Sec->sh_offset; const uint8_t *SecEndAddress = SecStartAddress + Sec->sh_size; @@ -692,9 +695,12 @@ static void printVersionDependencySection(ELFDumper *Dumper, return; unsigned VerNeedNum = 0; - for (const typename ELFO::Elf_Dyn &Dyn : Dumper->dynamic_table()) - if (Dyn.d_tag == DT_VERNEEDNUM) + for (const typename ELFO::Elf_Dyn &Dyn : Dumper->dynamic_table()) { + if (Dyn.d_tag == DT_VERNEEDNUM) { VerNeedNum = Dyn.d_un.d_val; + break; + } + } const uint8_t *SecData = (const uint8_t *)Obj->base() + Sec->sh_offset; const typename ELFO::Elf_Shdr *StrTab = -- 2.7.4