From c92de2f3fc81c701ab29408a8a84cd6e41e96fe5 Mon Sep 17 00:00:00 2001
From: "karl@kubx.ca" <karl@kubx.ca>
Date: Sat, 5 May 2018 10:44:20 -0400
Subject: [PATCH] Skip all ops with function attribute by default

---
 tensorflow/core/api_def/BUILD                              |  6 ------
 .../core/api_def/java_api/api_def_FilterDataset.pbtxt      |  4 ----
 .../core/api_def/java_api/api_def_FlatMapDataset.pbtxt     |  4 ----
 tensorflow/core/api_def/java_api/api_def_For.pbtxt         |  4 ----
 .../core/api_def/java_api/api_def_GeneratorDataset.pbtxt   |  4 ----
 .../api_def/java_api/api_def_GroupByWindowDataset.pbtxt    |  4 ----
 tensorflow/core/api_def/java_api/api_def_If.pbtxt          |  4 ----
 .../core/api_def/java_api/api_def_InterleaveDataset.pbtxt  |  4 ----
 .../core/api_def/java_api/api_def_MapAndBatchDataset.pbtxt |  4 ----
 tensorflow/core/api_def/java_api/api_def_MapDataset.pbtxt  |  4 ----
 .../core/api_def/java_api/api_def_OneShotIterator.pbtxt    |  4 ----
 .../java_api/api_def_ParallelInterleaveDataset.pbtxt       |  4 ----
 .../core/api_def/java_api/api_def_ParallelMapDataset.pbtxt |  4 ----
 tensorflow/core/api_def/java_api/api_def_RemoteCall.pbtxt  |  4 ----
 tensorflow/core/api_def/java_api/api_def_ScanDataset.pbtxt |  4 ----
 .../core/api_def/java_api/api_def_SymbolicGradient.pbtxt   |  4 ----
 tensorflow/core/api_def/java_api/api_def_While.pbtxt       |  4 ----
 tensorflow/java/BUILD                                      |  1 -
 tensorflow/java/src/gen/cc/op_generator.cc                 | 14 +++++++++++++-
 19 files changed, 13 insertions(+), 72 deletions(-)
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_FilterDataset.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_FlatMapDataset.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_For.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_GeneratorDataset.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_GroupByWindowDataset.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_If.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_InterleaveDataset.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_MapAndBatchDataset.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_MapDataset.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_OneShotIterator.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_ParallelInterleaveDataset.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_ParallelMapDataset.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_RemoteCall.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_ScanDataset.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_SymbolicGradient.pbtxt
 delete mode 100644 tensorflow/core/api_def/java_api/api_def_While.pbtxt

diff --git a/tensorflow/core/api_def/BUILD b/tensorflow/core/api_def/BUILD
index 06b797e..1454a1d 100644
--- a/tensorflow/core/api_def/BUILD
+++ b/tensorflow/core/api_def/BUILD
@@ -30,12 +30,6 @@ filegroup(
     visibility = ["//tensorflow:internal"],
 )
 
-filegroup(
-    name = "java_api_def",
-    srcs = glob(["java_api/*"]),
-    visibility = ["//tensorflow:internal"],
-)
-
 cc_library(
     name = "excluded_ops_lib",
     srcs = ["excluded_ops.cc"],
diff --git a/tensorflow/core/api_def/java_api/api_def_FilterDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_FilterDataset.pbtxt
deleted file mode 100644
index debd7e5..0000000
--- a/tensorflow/core/api_def/java_api/api_def_FilterDataset.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "FilterDataset"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_FlatMapDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_FlatMapDataset.pbtxt
deleted file mode 100644
index 329ab15..0000000
--- a/tensorflow/core/api_def/java_api/api_def_FlatMapDataset.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "FlatMapDataset"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_For.pbtxt b/tensorflow/core/api_def/java_api/api_def_For.pbtxt
deleted file mode 100644
index caabc94..0000000
--- a/tensorflow/core/api_def/java_api/api_def_For.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "For"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_GeneratorDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_GeneratorDataset.pbtxt
deleted file mode 100644
index a6e5167..0000000
--- a/tensorflow/core/api_def/java_api/api_def_GeneratorDataset.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "GeneratorDataset"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_GroupByWindowDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_GroupByWindowDataset.pbtxt
deleted file mode 100644
index 4c0b208..0000000
--- a/tensorflow/core/api_def/java_api/api_def_GroupByWindowDataset.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "GroupByWindowDataset"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_If.pbtxt b/tensorflow/core/api_def/java_api/api_def_If.pbtxt
deleted file mode 100644
index 13b8635..0000000
--- a/tensorflow/core/api_def/java_api/api_def_If.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "If"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_InterleaveDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_InterleaveDataset.pbtxt
deleted file mode 100644
index ed748d4..0000000
--- a/tensorflow/core/api_def/java_api/api_def_InterleaveDataset.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "InterleaveDataset"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_MapAndBatchDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_MapAndBatchDataset.pbtxt
deleted file mode 100644
index cb96bf6..0000000
--- a/tensorflow/core/api_def/java_api/api_def_MapAndBatchDataset.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "MapAndBatchDataset"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_MapDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_MapDataset.pbtxt
deleted file mode 100644
index e0ab8dd..0000000
--- a/tensorflow/core/api_def/java_api/api_def_MapDataset.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "MapDataset"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_OneShotIterator.pbtxt b/tensorflow/core/api_def/java_api/api_def_OneShotIterator.pbtxt
deleted file mode 100644
index 13130e6..0000000
--- a/tensorflow/core/api_def/java_api/api_def_OneShotIterator.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "OneShotIterator"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_ParallelInterleaveDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_ParallelInterleaveDataset.pbtxt
deleted file mode 100644
index 6a985d2..0000000
--- a/tensorflow/core/api_def/java_api/api_def_ParallelInterleaveDataset.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "ParallelInterleaveDataset"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_ParallelMapDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_ParallelMapDataset.pbtxt
deleted file mode 100644
index 64f25b9..0000000
--- a/tensorflow/core/api_def/java_api/api_def_ParallelMapDataset.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "ParallelMapDataset"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_RemoteCall.pbtxt b/tensorflow/core/api_def/java_api/api_def_RemoteCall.pbtxt
deleted file mode 100644
index 2ccb5c8..0000000
--- a/tensorflow/core/api_def/java_api/api_def_RemoteCall.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "RemoteCall"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_ScanDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_ScanDataset.pbtxt
deleted file mode 100644
index 3463e60..0000000
--- a/tensorflow/core/api_def/java_api/api_def_ScanDataset.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "ScanDataset"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_SymbolicGradient.pbtxt b/tensorflow/core/api_def/java_api/api_def_SymbolicGradient.pbtxt
deleted file mode 100644
index 88c3ace..0000000
--- a/tensorflow/core/api_def/java_api/api_def_SymbolicGradient.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "SymbolicGradient"
-  visibility: SKIP
-}
diff --git a/tensorflow/core/api_def/java_api/api_def_While.pbtxt b/tensorflow/core/api_def/java_api/api_def_While.pbtxt
deleted file mode 100644
index 3375668..0000000
--- a/tensorflow/core/api_def/java_api/api_def_While.pbtxt
+++ /dev/null
@@ -1,4 +0,0 @@
-op {
-  graph_op_name: "While"
-  visibility: SKIP
-}
\ No newline at end of file
diff --git a/tensorflow/java/BUILD b/tensorflow/java/BUILD
index 7cd0208..0cc8e7c 100644
--- a/tensorflow/java/BUILD
+++ b/tensorflow/java/BUILD
@@ -72,7 +72,6 @@ tf_java_op_gen_srcjar(
     name = "java_op_gen_sources",
     api_def_srcs = [
         "//tensorflow/core/api_def:base_api_def",
-        "//tensorflow/core/api_def:java_api_def",
     ],
     base_package = "org.tensorflow.op",
     gen_tool = ":java_op_gen_tool",
diff --git a/tensorflow/java/src/gen/cc/op_generator.cc b/tensorflow/java/src/gen/cc/op_generator.cc
index 7355b3a..f4cefbe 100644
--- a/tensorflow/java/src/gen/cc/op_generator.cc
+++ b/tensorflow/java/src/gen/cc/op_generator.cc
@@ -420,6 +420,18 @@ void GenerateOp(const OpSpec& op, const EndpointSpec& endpoint,
   writer.EndType();
 }
 
+bool CanGenerateOp(const OpDef& op_def, const ApiDef& api_def) {
+  if (api_def.visibility() == ApiDef::SKIP) {
+    return false;
+  }
+  for (const auto& attr : op_def.attr()) {
+    if (attr.type() == "func") {
+      return false;  // TODO(karllessard) add support for function attributes
+    }
+  }
+  return true;
+}
+
 }  // namespace
 
 Status OpGenerator::Run(const OpList& op_list, const string& base_package,
@@ -441,7 +453,7 @@ Status OpGenerator::Run(const OpList& op_list, const string& base_package,
   api_map.UpdateDocs();
   for (const auto& op_def : op_list.op()) {
     const ApiDef* api_def = api_map.GetApiDef(op_def.name());
-    if (api_def->visibility() != ApiDef::SKIP) {
+    if (CanGenerateOp(op_def, *api_def)) {
       OpSpec op(OpSpec::Create(op_def, *api_def));
       for (const EndpointSpec& endpoint : op.endpoints()) {
         GenerateOp(op, endpoint, base_package, output_dir, env_);
-- 
2.7.4