From c874fed3481638155a23601ce65985b2d0283e9c Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Thu, 22 Jun 2017 09:11:15 +1000 Subject: [PATCH] udev: consider a device with BTN_TRIGGER_HAPPY as joystick These buttons were added specifically for joysticks with lots of buttons, no other device should be using them. See kernel commit cf2f765f18960 "HID: handle joysticks with large number of buttons" We only test for BTN_TRIGGER_HAPPY (an alias for BTN_TRIGGER_HAPPY1) here, a device that sets buttons 2 and above but doesn't set 1 is considered buggy. https://github.com/systemd/systemd/issues/6137 Signed-off-by: Peter Hutterer --- src/udev/udev-builtin-input_id.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/udev/udev-builtin-input_id.c b/src/udev/udev-builtin-input_id.c index 4303b25..7ea86b2 100644 --- a/src/udev/udev-builtin-input_id.c +++ b/src/udev/udev-builtin-input_id.c @@ -206,6 +206,7 @@ static bool test_pointers(struct udev_device *dev, * rudders/pedals are joystick-like, but buttonless; they have * other fancy axes */ has_joystick_axes_or_buttons = test_bit(BTN_TRIGGER, bitmask_key) || + test_bit(BTN_TRIGGER_HAPPY, bitmask_key) || test_bit(BTN_A, bitmask_key) || test_bit(BTN_1, bitmask_key) || test_bit(ABS_RX, bitmask_abs) || -- 2.7.4