From c82a03ec1bb6ae7da4421076effc2139785dde77 Mon Sep 17 00:00:00 2001 From: Soo-Hyun Choi Date: Thu, 19 Sep 2013 14:52:47 +0900 Subject: [PATCH] Use local variable 'pkgId' instead of member variable 'm_pkgId' [Issue#] N/A [Problem] 'm_pkgId' is given as a parameter, pkgId, of setLabelForSharedDir(), but it still uses 'm_pkgId' inside of setLabelForSharedDir() function. [Cause] Declared a local variable which was not used correctly. [Solution] Changed 'm_pkgId' to 'pkgId'. Change-Id: If361b7481b49ab23b69ea947d01293f93105b0e3 --- src/jobs/widget_install/task_smack.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/jobs/widget_install/task_smack.cpp b/src/jobs/widget_install/task_smack.cpp index 2dc854c..cfac8b0 100644 --- a/src/jobs/widget_install/task_smack.cpp +++ b/src/jobs/widget_install/task_smack.cpp @@ -227,14 +227,14 @@ void TaskSmack::StepAbortSmack() bool TaskSmack::setLabelForSharedDir(const char* pkgId) { /* /shared directory */ - if (PC_OPERATION_SUCCESS != perm_app_setup_path(m_pkgId, + if (PC_OPERATION_SUCCESS != perm_app_setup_path(pkgId, m_context.locations->getSharedRootDir().c_str(), APP_PATH_ANY_LABEL, "_")) { _W("Add label to %s", m_context.locations->getUserDataRootDir().c_str()); } /* /shared/res directory */ - if (PC_OPERATION_SUCCESS != perm_app_setup_path(m_pkgId, + if (PC_OPERATION_SUCCESS != perm_app_setup_path(pkgId, m_context.locations->getSharedResourceDir().c_str(), APP_PATH_ANY_LABEL, "_")) { _W("Add label to %s", m_context.locations->getSharedResourceDir().c_str()); @@ -255,7 +255,7 @@ bool TaskSmack::setLabelForSharedDir(const char* pkgId) _D("sha1 label string : %s", sha1String.c_str()); - if (PC_OPERATION_SUCCESS != perm_app_setup_path(m_pkgId, + if (PC_OPERATION_SUCCESS != perm_app_setup_path(pkgId, m_context.locations->getSharedTrustedDir().c_str(), APP_PATH_GROUP_RW, sha1String.c_str())) { _W("Add label to %s", m_context.locations->getBinaryDir().c_str()); @@ -263,7 +263,7 @@ bool TaskSmack::setLabelForSharedDir(const char* pkgId) } /* /shared/data directory */ - if (PC_OPERATION_SUCCESS != perm_app_setup_path(m_pkgId, + if (PC_OPERATION_SUCCESS != perm_app_setup_path(pkgId, m_context.locations->getSharedDataDir().c_str(), APP_PATH_PUBLIC_RO)) { _W("Add label to %s", m_context.locations->getSharedDataDir().c_str()); -- 2.7.4