From c812cc021a8935f420ce599abe31ceb01b46070a Mon Sep 17 00:00:00 2001 From: Bruce Forstall Date: Thu, 27 Apr 2017 12:41:43 -0700 Subject: [PATCH] Remove unused TreeNodeInfo::isHelperCallWithKills field (dotnet/coreclr#11259) Remove unused TreeNodeInfo::isHelperCallWithKills field Commit migrated from https://github.com/dotnet/coreclr/commit/a07569230a248b5c927ef713863db17ffae44f16 --- src/coreclr/src/jit/lsra.cpp | 25 +++++-------------------- src/coreclr/src/jit/nodeinfo.h | 4 ---- 2 files changed, 5 insertions(+), 24 deletions(-) diff --git a/src/coreclr/src/jit/lsra.cpp b/src/coreclr/src/jit/lsra.cpp index 3718ddf..d558bcc 100644 --- a/src/coreclr/src/jit/lsra.cpp +++ b/src/coreclr/src/jit/lsra.cpp @@ -2747,16 +2747,6 @@ regMaskTP LinearScan::getKillSetForNode(GenTree* tree) } break; - case GT_LSH: - case GT_RSH: - case GT_RSZ: - case GT_ROL: - case GT_ROR: - if (tree->gtLsraInfo.isHelperCallWithKills) - { - killMask = RBM_CALLEE_TRASH; - } - break; case GT_RETURNTRAP: killMask = compiler->compHelperCallKillSet(CORINFO_HELP_STOP_FOR_GC); break; @@ -9943,12 +9933,11 @@ void TreeNodeInfo::Initialize(LinearScan* lsra, GenTree* node, LsraLocation loca dstCandidates = genRegMask(node->gtRegNum); } - internalIntCount = 0; - internalFloatCount = 0; - isLocalDefUse = false; - isHelperCallWithKills = false; - isLsraAdded = false; - definesAnyRegisters = false; + internalIntCount = 0; + internalFloatCount = 0; + isLocalDefUse = false; + isLsraAdded = false; + definesAnyRegisters = false; setDstCandidates(lsra, dstCandidates); srcCandsIndex = dstCandsIndex; @@ -10373,10 +10362,6 @@ void TreeNodeInfo::dump(LinearScan* lsra) { printf(" I"); } - if (isHelperCallWithKills) - { - printf(" H"); - } if (isLsraAdded) { printf(" A"); diff --git a/src/coreclr/src/jit/nodeinfo.h b/src/coreclr/src/jit/nodeinfo.h index 1937cc4..5f03da2 100644 --- a/src/coreclr/src/jit/nodeinfo.h +++ b/src/coreclr/src/jit/nodeinfo.h @@ -25,7 +25,6 @@ public: dstCandsIndex = 0; internalCandsIndex = 0; isLocalDefUse = false; - isHelperCallWithKills = false; isLsraAdded = false; isDelayFree = false; hasDelayFreeSrc = false; @@ -117,9 +116,6 @@ public: // nodes, or top-level nodes that are non-void. unsigned char isLocalDefUse : 1; - // isHelperCallWithKills is set when this is a helper call that kills more than just its in/out regs. - unsigned char isHelperCallWithKills : 1; - // Is this node added by LSRA, e.g. as a resolution or copy/reload move. unsigned char isLsraAdded : 1; -- 2.7.4