From c7dd1dcdd9b04cf8aae12c59091497d71fe54a15 Mon Sep 17 00:00:00 2001 From: Imre Deak Date: Mon, 22 Oct 2012 20:40:07 +0300 Subject: [PATCH] flip_test: add comment about the race between flip vs. vblank events Signed-off-by: Imre Deak Signed-off-by: Daniel Vetter --- tests/flip_test.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/flip_test.c b/tests/flip_test.c index b387bf5..7fed2f1 100644 --- a/tests/flip_test.c +++ b/tests/flip_test.c @@ -444,6 +444,11 @@ static unsigned int run_test_step(struct test_output *o) if (o->flags & TEST_VBLANK_ABSOLUTE) target_seq += o->vblank_state.last_seq; + /* + * It's possible that we don't have a pending flip here, in case both + * wf-vblank and flip were scheduled and the wf-vblank event was + * delivered earlier. The same applies to vblank events w.r.t flip. + */ do_flip = (o->flags & TEST_FLIP) && !(o->pending_events & EVENT_FLIP); do_vblank = (o->flags & TEST_VBLANK) && !(o->pending_events & EVENT_VBLANK); -- 2.7.4