From c720c1db11732e6e5ab60a6db41e155d4ab6f708 Mon Sep 17 00:00:00 2001 From: Han Zhu Date: Mon, 17 Apr 2023 10:08:34 -0700 Subject: [PATCH] Revert "[clang][cmake] Add options to pass in vcs repo and revision info" This reverts commit 1f5e737fc135bf991889a1364b8f8c5edc3953d2. --- clang/lib/Basic/CMakeLists.txt | 14 -------------- llvm/cmake/modules/GenerateVersionFromVCS.cmake | 14 ++++++-------- 2 files changed, 6 insertions(+), 22 deletions(-) diff --git a/clang/lib/Basic/CMakeLists.txt b/clang/lib/Basic/CMakeLists.txt index c05036a..8c828e4 100644 --- a/clang/lib/Basic/CMakeLists.txt +++ b/clang/lib/Basic/CMakeLists.txt @@ -14,19 +14,9 @@ set(generate_vcs_version_script "${LLVM_CMAKE_DIR}/GenerateVersionFromVCS.cmake" if(llvm_vc AND LLVM_APPEND_VC_REV) set(llvm_source_dir ${LLVM_MAIN_SRC_DIR}) endif() -if (LLVM_VC_REPOSITORY AND LLVM_VC_REVISION) - set(llvm_source_dir ${LLVM_SOURCE_DIR}) - set(llvm_vc_repository ${LLVM_VC_REPOSITORY}) - set(llvm_vc_revision ${LLVM_VC_REVISION}) -endif() if(clang_vc AND LLVM_APPEND_VC_REV) set(clang_source_dir ${CLANG_SOURCE_DIR}) endif() -if (CLANG_VC_REPOSITORY AND CLANG_VC_REVISION) - set(clang_source_dir ${CLANG_SOURCE_DIR}) - set(clang_vc_repository ${CLANG_VC_REPOSITORY}) - set(clang_vc_revision ${CLANG_VC_REVISION}) -endif() # Create custom target to generate the VC revision include. add_custom_command(OUTPUT "${version_inc}" @@ -34,11 +24,7 @@ add_custom_command(OUTPUT "${version_inc}" COMMAND ${CMAKE_COMMAND} "-DNAMES=\"LLVM;CLANG\"" "-DLLVM_SOURCE_DIR=${llvm_source_dir}" "-DCLANG_SOURCE_DIR=${clang_source_dir}" - "-DCLANG_VC_REPOSITORY=${clang_vc_repository}" - "-DCLANG_VC_REVISION=${clang_vc_revision}" "-DHEADER_FILE=${version_inc}" - "-DLLVM_VC_REPOSITORY=${llvm_vc_repository}" - "-DLLVM_VC_REVISION=${llvm_vc_revision}" -P "${generate_vcs_version_script}") # Mark the generated header as being generated. diff --git a/llvm/cmake/modules/GenerateVersionFromVCS.cmake b/llvm/cmake/modules/GenerateVersionFromVCS.cmake index d5bdf43..d8ec54d 100644 --- a/llvm/cmake/modules/GenerateVersionFromVCS.cmake +++ b/llvm/cmake/modules/GenerateVersionFromVCS.cmake @@ -18,7 +18,10 @@ include(VersionFromVCS) # Handle strange terminals set(ENV{TERM} "dumb") -function(append_info name revision repository) +function(append_info name path) + if(path) + get_source_info("${path}" revision repository) + endif() if(revision) file(APPEND "${HEADER_FILE}.tmp" "#define ${name}_REVISION \"${revision}\"\n") @@ -36,15 +39,10 @@ function(append_info name revision repository) endfunction() foreach(name IN LISTS NAMES) - if(${name}_VC_REPOSITORY AND ${name}_VC_REVISION) - set(revision ${${name}_VC_REVISION}) - set(repository ${${name}_VC_REPOSITORY}) - elseif(DEFINED ${name}_SOURCE_DIR) - get_source_info(${${name}_SOURCE_DIR} revision repository) - else() + if(NOT DEFINED ${name}_SOURCE_DIR) message(FATAL_ERROR "${name}_SOURCE_DIR is not defined") endif() - append_info(${name} ${revision} ${repository}) + append_info(${name} "${${name}_SOURCE_DIR}") endforeach() # Copy the file only if it has changed. -- 2.7.4