From c709a7c2b06cc388ab364015c433b95076d1eb56 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 2 Feb 2012 16:22:21 +0000 Subject: [PATCH] PR gdb/13405: * tui/tui-win.c (parse_scrolling_args): Don't write to possibly read-only memory. --- gdb/ChangeLog | 6 ++++++ gdb/tui/tui-win.c | 11 +++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4ca12dc..211af59 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2012-02-02 Tom Tromey + PR gdb/13405: + * tui/tui-win.c (parse_scrolling_args): Don't write to possibly + read-only memory. + +2012-02-02 Tom Tromey + PR gdb/9307: * symtab.c (lookup_language_this): Set block_found. diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c index a555145..b48bf3e 100644 --- a/gdb/tui/tui-win.c +++ b/gdb/tui/tui-win.c @@ -1583,13 +1583,16 @@ parse_scrolling_args (char *arg, ; if (*buf_ptr != (char) 0) - wname = buf_ptr; + { + wname = buf_ptr; + + /* Validate the window name. */ + for (i = 0; i < strlen (wname); i++) + wname[i] = toupper (wname[i]); + } else wname = "?"; - /* Validate the window name. */ - for (i = 0; i < strlen (wname); i++) - wname[i] = toupper (wname[i]); *win_to_scroll = tui_partial_win_by_name (wname); if (*win_to_scroll == (struct tui_win_info *) NULL -- 2.7.4