From c70698bcad55f0199f9616ac869168d3523cd6c7 Mon Sep 17 00:00:00 2001 From: David Svensson Fors Date: Thu, 22 Oct 2015 09:15:21 +0200 Subject: [PATCH] rtsp-stream: Always unref return value of gst_object_get_parent() Fixes a leak of a GstBin in the udp-mcast case. https://bugzilla.gnome.org/show_bug.cgi?id=756968 --- gst/rtsp-server/rtsp-stream.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gst/rtsp-server/rtsp-stream.c b/gst/rtsp-server/rtsp-stream.c index 4417c43..1c4366e 100644 --- a/gst/rtsp-server/rtsp-stream.c +++ b/gst/rtsp-server/rtsp-stream.c @@ -2843,7 +2843,6 @@ update_transport (GstRTSPStream * stream, GstRTSPStreamTransport * trans, gst_object_unref (pad); gst_object_unref (selpad); } - gst_object_unref (bin); priv->transport_sources = g_list_prepend (priv->transport_sources, source); @@ -2879,6 +2878,8 @@ update_transport (GstRTSPStream * stream, GstRTSPStreamTransport * trans, } } + gst_object_unref (bin); + /* fall through for the generic case */ } case GST_RTSP_LOWER_TRANS_UDP: -- 2.7.4