From c6801f502c4e58e2685ea2961a1b310692428bf3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Thu, 14 Dec 2017 14:36:03 +0100 Subject: [PATCH] meson-hwdb-update: fix undefined variable access I added the test if an optional parameter is not empty, but that doesn't work with -u. Provide an empty "fallback" value to fix the issue. Also group the update steps so that it's easier to see what is going on. --- tools/meson-hwdb-update.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/meson-hwdb-update.sh b/tools/meson-hwdb-update.sh index 33d603e..e9a78c6 100755 --- a/tools/meson-hwdb-update.sh +++ b/tools/meson-hwdb-update.sh @@ -2,7 +2,7 @@ cd "$1" -if [ "$2" != "-n" ]; then +if [ "${2:-}" != "-n" ]; then curl -L -o usb.ids 'http://www.linux-usb.org/usb.ids' curl -L -o pci.ids 'http://pci-ids.ucw.cz/v2.2/pci.ids' curl -L -o ma-large.txt 'http://standards-oui.ieee.org/oui/oui.txt' @@ -11,7 +11,9 @@ if [ "$2" != "-n" ]; then curl -L -o pnp_id_registry.html 'http://www.uefi.org/uefi-pnp-export' curl -L -o acpi_id_registry.html 'http://www.uefi.org/uefi-acpi-export' fi -./ids_parser.py + ./acpi-update.py >20-acpi-vendor.hwdb.base patch -p0 -o- 20-acpi-vendor.hwdb.base <20-acpi-vendor.hwdb.patch >20-acpi-vendor.hwdb ! diff -u 20-acpi-vendor.hwdb.base 20-acpi-vendor.hwdb >20-acpi-vendor.hwdb.patch + +./ids_parser.py -- 2.7.4