From c5797f859aa775633cd156432a1ed677974a52a6 Mon Sep 17 00:00:00 2001 From: machenbach Date: Mon, 27 Apr 2015 06:30:40 -0700 Subject: [PATCH] Revert of deprecate non-phantom weak callbacks (patchset #1 id:1 of https://codereview.chromium.org/1103173002/) Reason for revert: [Sheriff] Fails compilation on chromium android: http://build.chromium.org/p/client.v8/builders/Android%20Builder/builds/4131 Is the chromium version our builder used maybe too old (it uses lkcr)? In that case please reland as soon as it's up-to-date. Original issue's description: > deprecate non-phantom weak callbacks > > BUG= > > Committed: https://crrev.com/39c31da2142ab0fca9dae279b9e59cd4951a1982 > Cr-Commit-Position: refs/heads/master@{#28077} TBR=jochen@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1104163002 Cr-Commit-Position: refs/heads/master@{#28079} --- include/v8.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/v8.h b/include/v8.h index dd3fa51..bca6bf1 100644 --- a/include/v8.h +++ b/include/v8.h @@ -542,13 +542,13 @@ template class PersistentBase { * critical form of resource management! */ template - V8_INLINE V8_DEPRECATED( + V8_INLINE V8_DEPRECATE_SOON( "use WeakCallbackInfo version", void SetWeak(P* parameter, typename WeakCallbackData::Callback callback)); template - V8_INLINE V8_DEPRECATED( + V8_INLINE V8_DEPRECATE_SOON( "use WeakCallbackInfo version", void SetWeak(P* parameter, typename WeakCallbackData::Callback callback)); @@ -560,7 +560,7 @@ template class PersistentBase { // specify a parameter for the callback or the location of two internal // fields in the dying object. template - V8_INLINE V8_DEPRECATED( + V8_INLINE V8_DEPRECATE_SOON( "use SetWeak", void SetPhantom(P* parameter, typename WeakCallbackInfo

::Callback callback, -- 2.7.4