From c56ec7bedeb8b90cfef4c3ea8db3addfa34fde68 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Duncan=20P=2E=20N=2E=20Exon=C2=A0Smith?= Date: Thu, 5 Nov 2020 17:12:17 -0500 Subject: [PATCH] Tooling: Remove dead code for ToolingInvocation::mapVirtualFile Follows through on c4cb3b10dc8c50e46c9fb1b7ae95e3c3c94975d3's FIXME dating back to 2015. Anyone using this should migrate to InMemoryFileSystem and/or ClangTool::mapVirtualFile. Differential Revision: https://reviews.llvm.org/D90885 --- clang/include/clang/Tooling/Tooling.h | 11 ----------- clang/lib/Tooling/Tooling.cpp | 14 -------------- 2 files changed, 25 deletions(-) diff --git a/clang/include/clang/Tooling/Tooling.h b/clang/include/clang/Tooling/Tooling.h index 4fb0c18..8b3b2e5 100644 --- a/clang/include/clang/Tooling/Tooling.h +++ b/clang/include/clang/Tooling/Tooling.h @@ -265,21 +265,12 @@ public: this->DiagConsumer = DiagConsumer; } - /// Map a virtual file to be used while running the tool. - /// - /// \param FilePath The path at which the content will be mapped. - /// \param Content A null terminated buffer of the file's content. - // FIXME: remove this when all users have migrated! - void mapVirtualFile(StringRef FilePath, StringRef Content); - /// Run the clang invocation. /// /// \returns True if there were no errors during execution. bool run(); private: - void addFileMappingsTo(SourceManager &SourceManager); - bool runInvocation(const char *BinaryName, driver::Compilation *Compilation, std::shared_ptr Invocation, @@ -290,8 +281,6 @@ public: bool OwnsAction; FileManager *Files; std::shared_ptr PCHContainerOps; - // Maps -> . - llvm::StringMap MappedFileContents; DiagnosticConsumer *DiagConsumer = nullptr; }; diff --git a/clang/lib/Tooling/Tooling.cpp b/clang/lib/Tooling/Tooling.cpp index b0d3f5c..063f4df 100644 --- a/clang/lib/Tooling/Tooling.cpp +++ b/clang/lib/Tooling/Tooling.cpp @@ -319,12 +319,6 @@ ToolInvocation::~ToolInvocation() { delete Action; } -void ToolInvocation::mapVirtualFile(StringRef FilePath, StringRef Content) { - SmallString<1024> PathStorage; - llvm::sys::path::native(FilePath, PathStorage); - MappedFileContents[PathStorage] = Content; -} - bool ToolInvocation::run() { std::vector Argv; for (const std::string &Str : CommandLine) @@ -359,14 +353,6 @@ bool ToolInvocation::run() { return false; std::unique_ptr Invocation( newInvocation(&Diagnostics, *CC1Args, BinaryName)); - // FIXME: remove this when all users have migrated! - for (const auto &It : MappedFileContents) { - // Inject the code as the given file name into the preprocessor options. - std::unique_ptr Input = - llvm::MemoryBuffer::getMemBuffer(It.getValue()); - Invocation->getPreprocessorOpts().addRemappedFile(It.getKey(), - Input.release()); - } return runInvocation(BinaryName, Compilation.get(), std::move(Invocation), std::move(PCHContainerOps)); } -- 2.7.4