From c551dab0b57757607dd27a1ed764e6d3f9e9fdbd Mon Sep 17 00:00:00 2001 From: Gao Xiang Date: Mon, 9 Sep 2024 19:13:05 +0800 Subject: [PATCH] erofs-utils: mkfs: fix inaccurate assertion of hardlinks in rebuild mode `erofs_parent_inode(inode) == dir` is only true for non-hardlink inodes and directories. Only debug builds are impacted. Signed-off-by: Gao Xiang Link: https://lore.kernel.org/r/20240909111305.1850391-1-hsiangkao@linux.alibaba.com --- lib/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/inode.c b/lib/inode.c index d464bc6..bc3cb76 100644 --- a/lib/inode.c +++ b/lib/inode.c @@ -1744,7 +1744,8 @@ static int erofs_mkfs_dump_tree(struct erofs_inode *root, bool rebuild, continue; if (!erofs_inode_visited(inode)) { - DBG_BUGON(rebuild && + DBG_BUGON(rebuild && (inode->i_nlink == 1 || + S_ISDIR(inode->i_mode)) && erofs_parent_inode(inode) != dir); erofs_mark_parent_inode(inode, dir); -- 2.34.1