From c50094bda33c5d503c5447c5b69f1f5272e94ca0 Mon Sep 17 00:00:00 2001 From: "jkummerow@chromium.org" Date: Thu, 18 Aug 2011 12:33:40 +0000 Subject: [PATCH] Fix another handful of memory leaks TEST=valgrind reports 0 bytes definitely lost for cctest/test-api/RunTwoIsolatesOnSingleThread Review URL: http://codereview.chromium.org/7621064 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8968 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/isolate.cc | 2 ++ src/spaces.h | 1 + src/v8threads.cc | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/isolate.cc b/src/isolate.cc index e0dfea8..09cbc8a 100644 --- a/src/isolate.cc +++ b/src/isolate.cc @@ -1573,6 +1573,8 @@ Isolate::~Isolate() { handle_scope_implementer_ = NULL; delete break_access_; break_access_ = NULL; + delete debugger_access_; + debugger_access_ = NULL; delete compilation_cache_; compilation_cache_ = NULL; diff --git a/src/spaces.h b/src/spaces.h index d8ed27e..a0f4ba1 100644 --- a/src/spaces.h +++ b/src/spaces.h @@ -409,6 +409,7 @@ class Space : public Malloced { class CodeRange { public: explicit CodeRange(Isolate* isolate); + ~CodeRange() { TearDown(); } // Reserves a range of virtual memory, but does not commit any of it. // Can only be called once, at heap initialization time. diff --git a/src/v8threads.cc b/src/v8threads.cc index 52f82e2..3881d66 100644 --- a/src/v8threads.cc +++ b/src/v8threads.cc @@ -305,7 +305,9 @@ ThreadManager::ThreadManager() ThreadManager::~ThreadManager() { - // TODO(isolates): Destroy mutexes. + delete mutex_; + delete free_anchor_; + delete in_use_anchor_; } -- 2.7.4