From c4e177c049c2cd1513d81421dab31f8d4b5123e4 Mon Sep 17 00:00:00 2001 From: Aaron Kennedy Date: Thu, 23 Feb 2012 09:50:15 +0000 Subject: [PATCH] Allow V8 bindings to assign to value type sub properties This was an overly defensive change because it wasn't clear if the isAlias check would catch aliased value type sub properties. Change-Id: Iee2805d22f281c1fd188b14e265687fd8e7042db Reviewed-by: Roberto Raggi --- src/declarative/qml/qdeclarativecompiler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/declarative/qml/qdeclarativecompiler.cpp b/src/declarative/qml/qdeclarativecompiler.cpp index c4efc85..b7b882c 100644 --- a/src/declarative/qml/qdeclarativecompiler.cpp +++ b/src/declarative/qml/qdeclarativecompiler.cpp @@ -3609,7 +3609,7 @@ bool QDeclarativeCompiler::completeComponentBuild() bool isSharable = false; binding.rewrittenExpression = rewriteBinding(binding.expression.asAST(), expression, &isSharable); - if (isSharable && !binding.property->isValueTypeSubProperty && !binding.property->isAlias /* See above re alias */ && + if (isSharable && !binding.property->isAlias /* See above re alias */ && binding.property->type != qMetaTypeId()) { binding.dataType = BindingReference::V8; sharedBindings.append(b); -- 2.7.4