From c4c96f9e707a465475973d2f669d95a5c6e9a519 Mon Sep 17 00:00:00 2001 From: "peter.rybin@gmail.com" Date: Mon, 25 Jun 2012 22:20:52 +0000 Subject: [PATCH] Revert 11927 "Fix liveedit heap traversal bug with write barrier" A test was broken by r11927 Review URL: https://chromiumcodereview.appspot.com/10667025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11928 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/liveedit.cc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/liveedit.cc b/src/liveedit.cc index d99c4a0..80e18bb 100644 --- a/src/liveedit.cc +++ b/src/liveedit.cc @@ -968,14 +968,6 @@ class ReplacingVisitor : public ObjectVisitor { static void ReplaceCodeObject(Code* original, Code* substitution) { ASSERT(!HEAP->InNewSpace(substitution)); - // Perform a full GC in order to ensure that we are not in the middle of an - // incremental marking phase when we are replacing the code object. - // Since we are not in an incremental marking phase we can write pointers - // to code objects (that are never in new space) without worrying about - // write barriers. - HEAP->CollectAllGarbage(Heap::kMakeHeapIterableMask, - "liveedit.cc ReplaceCodeObject"); - AssertNoAllocation no_allocations_please; ReplacingVisitor visitor(original, substitution); -- 2.7.4