From c44990d843478a546de5ce0f0d548691718dfd24 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=EB=B0=95=EC=A2=85=ED=98=84/On-Device=20Lab=28SR=29/Staff?= =?utf8?q?=20Engineer/=EC=82=BC=EC=84=B1=EC=A0=84=EC=9E=90?= Date: Fri, 8 Feb 2019 10:43:03 +0900 Subject: [PATCH] [coco.generic] Declare visibility explicitly (#3009) This commit updates coco_generic build script to declare visibilties of each dependent libraries explicitly. Signed-off-by: Jonghyun Park --- contrib/coco/generic/CMakeLists.txt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/contrib/coco/generic/CMakeLists.txt b/contrib/coco/generic/CMakeLists.txt index a976f16..e881447 100644 --- a/contrib/coco/generic/CMakeLists.txt +++ b/contrib/coco/generic/CMakeLists.txt @@ -4,9 +4,8 @@ list(REMOVE_ITEM SOURCES ${TESTS}) add_library(coco_generic SHARED ${SOURCES}) target_include_directories(coco_generic PUBLIC include) -target_link_libraries(coco_generic coco_core) -# TODO Set this as PRIVATE dependency -target_link_libraries(coco_generic stdex) +target_link_libraries(coco_generic PUBLIC coco_core) +target_link_libraries(coco_generic PRIVATE stdex) nncc_find_package(GTest QUIET) @@ -18,3 +17,6 @@ nncc_include(OptionalTargetTools) coco_add_test(coco_generic_test ${TESTS}) optional_target_link_libraries(coco_generic_test coco_generic) +# stdex is a PRIVATE dependency of coco_generic, and thus is not linked to coco_generic_test +# even though coco_generic_test is linked to coco_generic +optional_target_link_libraries(coco_generic_test stdex) -- 2.7.4