From c42640c74813f5c9aa9d0d3bdad5ebd565bdfcdc Mon Sep 17 00:00:00 2001 From: "xypron.glpk@gmx.de" Date: Mon, 8 May 2017 20:40:16 +0200 Subject: [PATCH] pci: avoid memory leak strdup uses malloc to allocate memory for str. If we cannot bind to the generic driver we should release the memory. The problem was indicated by clang scan-build. Signed-off-by: Heinrich Schuchardt Reviewed-by: Bin Meng --- drivers/pci/pci-uclass.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index 40f59c0..504d7e3 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -660,6 +660,7 @@ static int pci_find_and_bind_driver(struct udevice *parent, ret = device_bind_driver(parent, drv, str, devp); if (ret) { debug("%s: Failed to bind generic driver: %d\n", __func__, ret); + free(str); return ret; } debug("%s: No match found: bound generic driver instead\n", __func__); -- 2.7.4