From c33bd0123ed605d201ee43dcd80998b6ab858022 Mon Sep 17 00:00:00 2001 From: Ulrich Drepper Date: Wed, 14 Jul 1999 15:10:51 +0000 Subject: [PATCH] Update. 1999-07-13 Andreas Schwab * elf/dl-runtime.c (fixup, profile_fixup): Call alloca to prevent inlining. Fixes PR libc/1198. --- ChangeLog | 5 +++++ elf/dl-runtime.c | 12 ++++++++++++ 2 files changed, 17 insertions(+) diff --git a/ChangeLog b/ChangeLog index 2b03ad4..064d5ed 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +1999-07-13 Andreas Schwab + + * elf/dl-runtime.c (fixup, profile_fixup): Call alloca to prevent + inlining. Fixes PR libc/1198. + 1999-07-14 Andreas Schwab * Makerules (common-generated): Don't prepend $(common-objpfx). diff --git a/elf/dl-runtime.c b/elf/dl-runtime.c index a0f54bd..9f3004e 100644 --- a/elf/dl-runtime.c +++ b/elf/dl-runtime.c @@ -57,6 +57,12 @@ fixup ( void *const rel_addr = (void *)(l->l_addr + reloc->r_offset); ElfW(Addr) value; + /* The use of `alloca' here looks ridiculous but it helps. The goal is + to prevent the function from being inlined and thus optimized out. + There is no official way to do this so we use this trick. gcc never + inlines functions which use `alloca'. */ + alloca (sizeof (int)); + /* Sanity check that we're really looking at a PLT relocation. */ assert (ELFW(R_TYPE)(reloc->r_info) == ELF_MACHINE_JMP_SLOT); @@ -110,6 +116,12 @@ profile_fixup ( ElfW(Addr) *resultp; ElfW(Addr) value; + /* The use of `alloca' here looks ridiculous but it helps. The goal is + to prevent the function from being inlined, and thus optimized out. + There is no official way to do this so we use this trick. gcc never + inlines functions which use `alloca'. */ + alloca (sizeof (int)); + /* This is the address in the array where we store the result of previous relocations. */ resultp = &l->l_reloc_result[reloc_offset / sizeof (PLTREL)]; -- 2.7.4