From c2f901dfb6cb5ae2845a48503df1fe0065085f83 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Wed, 6 Apr 2016 16:49:37 -0400 Subject: [PATCH] Fix gdb.threads/dlopen-libpthread.exp crash Following, commit 6e774b13c3b81ac2599812adf058796948ce7e95 Make ftrace tests work with remote targets the test gdb.threads/dlopen-libpthread.exp started to fail with: ERROR: error copying "/home/emaisin/build/binutils-gdb/gdb/testsuite/gdb.threads/dlopen-libpthread.so": no such file or directory This is because the library path is not computed using standard_output_file, so we try to gdb_load_shlibs an unexisting file. gdb/testsuite/ChangeLog: * gdb.threads/dlopen-libpthread.exp: Set binfile_lib using standard_output_file. Remove unused binfile variable. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.threads/dlopen-libpthread.exp | 3 +-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 27806a0..df16023 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-04-06 Simon Marchi + + * gdb.threads/dlopen-libpthread.exp: Set binfile_lib using + standard_output_file. Remove unused binfile variable. + 2016-04-05 Catalin Udma * gdb.python/py-mi-objfile-gdb.py: Use "list main" command. diff --git a/gdb/testsuite/gdb.threads/dlopen-libpthread.exp b/gdb/testsuite/gdb.threads/dlopen-libpthread.exp index 33789cc..206b16a 100644 --- a/gdb/testsuite/gdb.threads/dlopen-libpthread.exp +++ b/gdb/testsuite/gdb.threads/dlopen-libpthread.exp @@ -23,8 +23,7 @@ set testfile "dlopen-libpthread" set srcmainfile ${testfile}.c set srclibfile ${testfile}-lib.c set executable ${testfile} -set binfile_lib ${objdir}/${subdir}/${executable}.so -set binfile ${objdir}/${subdir}/${executable} +set binfile_lib [standard_output_file ${executable}.so] set lib_dlopen [shlib_target_file ${executable}.so] # Use build_executable_own_libs as prelinked libpthread.so can produce false -- 2.7.4