From c2bb73fc8d88ba6e05ac7938385223302a2669d7 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Sat, 20 Jul 2013 23:33:15 +0000 Subject: [PATCH] Don't crash when llvm.compiler.used becomes empty. GlobalOpt simplifies llvm.compiler.used by removing any members that are also in the more strict llvm.used. Handle the special case where llvm.compiler.used becomes empty. llvm-svn: 186778 --- llvm/lib/Transforms/IPO/GlobalOpt.cpp | 5 +++++ llvm/test/Transforms/GlobalOpt/compiler-used.ll | 16 ++++++++++++++++ 2 files changed, 21 insertions(+) create mode 100644 llvm/test/Transforms/GlobalOpt/compiler-used.ll diff --git a/llvm/lib/Transforms/IPO/GlobalOpt.cpp b/llvm/lib/Transforms/IPO/GlobalOpt.cpp index 669162c..183a599 100644 --- a/llvm/lib/Transforms/IPO/GlobalOpt.cpp +++ b/llvm/lib/Transforms/IPO/GlobalOpt.cpp @@ -3070,6 +3070,11 @@ static int compareNames(const void *A, const void *B) { static void setUsedInitializer(GlobalVariable &V, SmallPtrSet Init) { + if (Init.empty()) { + V.eraseFromParent(); + return; + } + SmallVector UsedArray; PointerType *Int8PtrTy = Type::getInt8PtrTy(V.getContext()); diff --git a/llvm/test/Transforms/GlobalOpt/compiler-used.ll b/llvm/test/Transforms/GlobalOpt/compiler-used.ll new file mode 100644 index 0000000..a710d27 --- /dev/null +++ b/llvm/test/Transforms/GlobalOpt/compiler-used.ll @@ -0,0 +1,16 @@ +; RUN: opt < %s -globalopt -S | FileCheck %s + +; Test that when all members of llvm.compiler.used are found to be redundant +; we delete it instead of crashing. + +define void @foo() { + ret void +} + +@llvm.used = appending global [1 x i8*] [i8* bitcast (void ()* @foo to i8*)], section "llvm.metadata" + +@llvm.compiler.used = appending global [1 x i8*] [i8* bitcast (void ()* @foo to i8*)], section "llvm.metadata" + +; CHECK-NOT: @llvm.compiler.used +; CHECK: @llvm.used = appending global [1 x i8*] [i8* bitcast (void ()* @foo to i8*)], section "llvm.metadata" +; CHECK-NOT: @llvm.compiler.used -- 2.7.4