From c29ab86fae1e3e6e08b5ae76a9c51f35581e9e9e Mon Sep 17 00:00:00 2001 From: Youngjae Cho Date: Tue, 5 Apr 2022 17:29:24 -0700 Subject: [PATCH] usb: prevent not null-terminated string Change-Id: I17b1d4c7753120dd09192523f75c8939ba96e184 Signed-off-by: Youngjae Cho --- src/usb/usb-state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/usb/usb-state.c b/src/usb/usb-state.c index 77375c6..51fa4cb 100644 --- a/src/usb/usb-state.c +++ b/src/usb/usb-state.c @@ -174,7 +174,8 @@ static void parse_property_systemd_unit(gpointer data, gpointer udata) struct service_config *svc = (struct service_config *) udata; if (MATCH(prop->key, "Service")) { - strncpy(svc->name, prop->value, sizeof(svc->name)); + strncpy(svc->name, prop->value, sizeof(svc->name) - 1); + svc->name[sizeof(svc->name) - 1] = '\0'; } else if (MATCH(prop->key, "RemainAfterDisable")) { svc->remain_after_disable = MATCH(prop->value, "yes"); } -- 2.7.4