From c23f9867e7a0deb428e9eaead75d7ae0a97090fc Mon Sep 17 00:00:00 2001 From: "ricow@chromium.org" Date: Thu, 22 Sep 2011 14:43:23 +0000 Subject: [PATCH] Don't take heap snapshot when doing Heap::RecordStats from OOM cases. Filled issue 1718 to track this. Review URL: http://codereview.chromium.org/7995003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9397 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/api.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/api.cc b/src/api.cc index 6479ad0..ed87fa0 100644 --- a/src/api.cc +++ b/src/api.cc @@ -185,7 +185,10 @@ void i::V8::FatalProcessOutOfMemory(const char* location, bool take_snapshot) { int end_marker; heap_stats.end_marker = &end_marker; i::Isolate* isolate = i::Isolate::Current(); - isolate->heap()->RecordStats(&heap_stats, take_snapshot); + // BUG(1718): + // Don't use the take_snapshot since we don't support HeapIterator here + // without doing a special GC. + isolate->heap()->RecordStats(&heap_stats, false); i::V8::SetFatalError(); FatalErrorCallback callback = GetFatalErrorHandler(); { -- 2.7.4