From c1860a68483ebd0ca859fa24fc0e0426d862d0a9 Mon Sep 17 00:00:00 2001 From: Pierre-Eric Pelloux-Prayer Date: Thu, 16 Dec 2021 12:06:52 +0100 Subject: [PATCH] radeonsi: don't use perp. end caps when line smoothing is on MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The line smoothing algorithm causes the diagonal line to be visible. See: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13700#note_1187405 Fixes: 45717780082 ("radeonsi: set PERPENDICULAR_ENDCAP_ENA for wide AA lines") Reviewed-by: Marek Olšák Part-of: --- src/gallium/drivers/radeonsi/si_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index c942b33..e82235d 100644 --- a/src/gallium/drivers/radeonsi/si_state.c +++ b/src/gallium/drivers/radeonsi/si_state.c @@ -951,7 +951,7 @@ static void *si_create_rs_state(struct pipe_context *ctx, const struct pipe_rast : 0; /* TODO: implement line stippling with perpendicular end caps. */ /* Line width > 2 is an internal recommendation. */ - rs->perpendicular_end_caps = (state->multisample || state->line_smooth) && + rs->perpendicular_end_caps = state->multisample && state->line_width > 2 && !state->line_stipple_enable; rs->pa_cl_clip_cntl = S_028810_DX_CLIP_SPACE_DEF(state->clip_halfz) | -- 2.7.4